1686616 - Migrate all Services.py interfaces to components.conf

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Aria Beingessner [:Gankra]]

Services.py has effectively been replaced by the more robust components.conf system. We should deprecate the former because it's slower and less safe.

Comment 1

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - Port all C++ code using Services.h to Components.h. r?kmag

Basically all mechanical find-replace with a few hand fixups. Services.py
is still needed to generates services.rs, but I've deleted everything
that Rust doesn't use (almost everything).

Comment 2

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - register all Services.py services with components.conf. r?kmag

These services had their name added to components.conf:

• GfxInfo
• ThirdPartyUtil
• History
• HttpActivityDistributor
• UUIDGenerator
• ServiceWorkerManager
• PermissionManager

These services were added to componenets.conf under a different name:

• DirectoryService => Directory
• IOService => IO
• StringBundleService => StringBundle
• CacheStorageService => CacheStorage
• StreamTransportService => StreamTransport
• SocketTransportService => SocketTransport

These preferences weren't migrated to components.conf because only Rust
code uses them:

• RemoteAgent
• XULRuntime
• PrefService

These services weren't migrated to components.conf because they're unused:

• ToolkitChromeRegistry (used as ChromeRegistry)
• XULChromeRegistry (used as ChromeRegistry)
• Bits (completely unused)

These services were already available in components.conf but are still
used by rust code:

• URIFixup

These services weren't migrated because they will be handled in
subsequent patchsets:

• ObserverService

For the record, the following Services are being used by Rust code
and must remain until a Rust version of Components.h is written:

• RemoteAgent
• XULRuntime
• PrefService
• URIFixup
• ObserverService
• DirectoryService
• ThirdPartyUtil

Comment 3

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make GfxInfo use Components instead of Services. r?kmag

Depends on D105521

Comment 4

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make ThirdPartyUtil use Components instead of Services. r?kmag

Depends on D105522

Comment 5

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make History use Components instead of Services. r?kmag

Depends on D105523

Comment 6

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make HttpActivityDistributor use Components instead of Services. r?kmag

Depends on D105524

Comment 7

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make UUIDGenerator use Components instead of Services. r?kmag

Depends on D105525

Comment 8

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make ServiceWorkerManager use Components instead of Services. r?kmag

Depends on D105526

Comment 9

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make PermissionManager use Components instead of Services. r?kmag

Depends on D105527

Comment 10

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make Directory use Components instead of Services. r?kmag

Depends on D105528

Comment 11

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make IO use Components instead of Services. r?kmag

Depends on D105529

Comment 12

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make StringBundle use Components instead of Services. r?kmag

Depends on D105530

Comment 13

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make CacheStorage use Components instead of Services. r?kmag

Depends on D105531

Comment 14

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make StreamTransport use Components instead of Services. r?kmag

Depends on D105532

Comment 15

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - make SocketTransport use Components instead of Services. r?kmag

Depends on D105533

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2473a904aa80
register all Services.py services with components.conf. r=kmag,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/8d41504bf834
make GfxInfo use Components instead of Services. r=kmag
https://hg.mozilla.org/integration/autoland/rev/9948eb32fcdc
make ThirdPartyUtil use Components instead of Services. r=kmag
https://hg.mozilla.org/integration/autoland/rev/f6a2f878fa0f
make History use Components instead of Services. r=kmag
https://hg.mozilla.org/integration/autoland/rev/83cea9a71527
make HttpActivityDistributor use Components instead of Services. r=kmag,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/18b51f552cec
make UUIDGenerator use Components instead of Services. r=kmag
https://hg.mozilla.org/integration/autoland/rev/6a5f3317cc4a
make ServiceWorkerManager use Components instead of Services. r=kmag
https://hg.mozilla.org/integration/autoland/rev/81accf94ee9f
make PermissionManager use Components instead of Services. r=kmag
https://hg.mozilla.org/integration/autoland/rev/832de017f827
make Directory use Components instead of Services. r=kmag
https://hg.mozilla.org/integration/autoland/rev/b37b84e13f00
make IO use Components instead of Services. r=kmag
https://hg.mozilla.org/integration/autoland/rev/3ad4d0b12a62
make StringBundle use Components instead of Services. r=kmag
https://hg.mozilla.org/integration/autoland/rev/6b23a123adcb
make CacheStorage use Components instead of Services. r=kmag,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/2337db198699
make StreamTransport use Components instead of Services. r=kmag,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/4814392b66bd
make SocketTransport use Components instead of Services. r=kmag,necko-reviewers,valentin

Comment 17

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2473a904aa80
https://hg.mozilla.org/mozilla-central/rev/8d41504bf834
https://hg.mozilla.org/mozilla-central/rev/9948eb32fcdc
https://hg.mozilla.org/mozilla-central/rev/f6a2f878fa0f
https://hg.mozilla.org/mozilla-central/rev/83cea9a71527
https://hg.mozilla.org/mozilla-central/rev/18b51f552cec
https://hg.mozilla.org/mozilla-central/rev/6a5f3317cc4a
https://hg.mozilla.org/mozilla-central/rev/81accf94ee9f
https://hg.mozilla.org/mozilla-central/rev/832de017f827
https://hg.mozilla.org/mozilla-central/rev/b37b84e13f00
https://hg.mozilla.org/mozilla-central/rev/3ad4d0b12a62
https://hg.mozilla.org/mozilla-central/rev/6b23a123adcb
https://hg.mozilla.org/mozilla-central/rev/2337db198699
https://hg.mozilla.org/mozilla-central/rev/4814392b66bd

Comment 18

[Aria Beingessner [:Gankra]]

Still have to do ObserverService.

Comment 19

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - Make the ObserverService a named Observer component. r?kmag

Comment 20

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - Bulk convert all uses of ObserverService to use Components. r?kmag

As well as fixup the includes of every file this touches wrt services.h\components.h.
This is all the automated\trivial changes -- the next commit will do the hand-edits.

Depends on D105848

Comment 21

[Aria Beingessner [:Gankra]]

Attachment: Bug 1686616 - Cleanup remnants of services.h's removal from cpp code. r?kmag

CookieCommons.h was relying on implicitly including ThirdPartyUtils from Services.h

Database had one remaining use of services that slipped past previous rounds.

Depends on D105849

Comment 22

[Aria Beingessner [:Gankra]]

This is blocked on the above ObserverService change causing mysterious crashes. Changing all of those points seems to cause a fundamental change in how the ObserverService is created/destroyed in some subtle way that I wasn't able to isolate. I tried binary searching which usage sites were problematic but it seemed to be unstable / some combination of multiple sites?

At this point someone more experienced with the services system needs to finish this up, unfortunately.

Comment 23

[Andrew McCreight [:mccr8]]

It looks like a ton of patches landed in this bug, so let's just close it. I filed a new bug, bug 1773085, for the remaining work.