1686828 - http://forums.mozillazine.org/ can not be loaded completely with uBlock Origin installed

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Kershaw Chang [:kershaw]]

See bug 1686611 comment #0 about http://forums.mozillazine.org/.

Comment 1

[Loïc Yhuel]

Attachment: log.txt-main.6872.moz_log.zip

New HTTP log.
In the browser console, I saw :

• GET http://forums.mozillazine.org/ OK (172ms blocked, 521ms DNS, 160ms connection, 909ms wait, 319ms receive)
• GET http://www.google.com/coop/cse/brand?form=cse-search-box&lang=en Blocked By Extension
• GET http://forums.mozillazine.org/static/common/images/navHeader.gif still pending (2ms blocked, all other timings at 0ms)

Comment 2

[Loïc Yhuel]

Same with http://ip.lafibre.info, and even sometimes with the even simpler http://ipv4.lafibre.info.
Again, I do not have any issue if I set network.dns.upgrade_with_https_rr=false.

I saw cases where only the HTML was loaded, the page was blank, with the favicon request pending.
When retrying the load without cache several times on http://ipv4.lafibre.info, I saw cases where the request for the image was not listed in the browser console, and the page was displayed without it. The load was sometimes still pending, sometimes finished (with no image).

Comment 3

[Dragana Damjanovic [:dragana]]

Kershaw should we disable it for now?

Comment 4

[Kershaw Chang [:kershaw]]

(In reply to Dragana Damjanovic [:dragana] from comment #3)

Kershaw should we disable it for now?

Ok, let's disable this.

Comment 5

[Kershaw Chang [:kershaw]]

(In reply to Loïc Yhuel from comment #2)

Same with http://ip.lafibre.info, and even sometimes with the even simpler http://ipv4.lafibre.info.
Again, I do not have any issue if I set network.dns.upgrade_with_https_rr=false.

I saw cases where only the HTML was loaded, the page was blank, with the favicon request pending.
When retrying the load without cache several times on http://ipv4.lafibre.info, I saw cases where the request for the image was not listed in the browser console, and the page was displayed without it. The load was sometimes still pending, sometimes finished (with no image).

Could you also get the log for http://ipv4.lafibre.info?
Thanks.

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Bug 1686828 - Disable network.dns.upgrade_with_https_rr

Comment 7

[Gary [:streetwolf52]]

http://forum.gigabyte.us/ appears to have the same issue as the mozillazine forum.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/595a8f4c77e8
Disable network.dns.upgrade_with_https_rr r=dragana

Comment 9

[Loïc Yhuel]

(In reply to Gary [:streetwolf52] from comment #7)

http://forum.gigabyte.us/ appears to have the same issue as the mozillazine forum.

No issue for me on this one.

Comment 10

[Loïc Yhuel]

Attachment: ipv4.lafibre.info http log

I was having difficulties reproducing the issue with http://ipv4.lafibre.info/ (it's easier with the slightly bigger http://ip.lafibre.info/).
I updated to the latest nightly (20210115125655), waited a few minutes for all activity to settle, and opened http://ipv4.lafibre.info/ in a new tab from the link on this page : the HTML is displayed, but without the image, and the page is still loading.

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/595a8f4c77e8

Comment 12

[Kershaw Chang [:kershaw]]

I've found the problem. See the log below. nsHttpChannel::OnHTTPSRRAvailable is caled before nsHttpChannel::MaybeUseHTTPSRRForUpgrade and the code here only handles the case where mHTTPSSVCRecord is not empty.

2021-01-15 10:29:12.582000 UTC - [Parent 6872: Main Thread]: V/nsHttp nsHttpChannel::OnHTTPSRRAvailable [this=000001E005A07000, aRecord=0000000000000000]
2021-01-15 10:29:12.607 ⁃ nsHttpChannel ⁃ 1dff0976000 ⁃ released ⁃ status=n/a ⁃ http-status=n/a ⁃ url=https://mozilla.cloudflare-dns.com/dns-query
2021-01-15 10:29:12.620000 UTC - [Parent 6872: Main Thread]: V/nsHttp nsHttpChannel::ResumeInternal [this=000001E005A07000]
2021-01-15 10:29:12.620000 UTC - [Parent 6872: Main Thread]: V/nsHttp 000001E005A07000 called from script: resource://gre/modules/WebRequest.jsm:1077:14
2021-01-15 10:29:12.621000 UTC - [Parent 6872: Main Thread]: V/nsHttp nsHttpChannel::HandleOnBeforeConnect [this=000001E005A07000]
2021-01-15 10:29:12.621000 UTC - [Parent 6872: Main Thread]: V/nsHttp nsHttpChannel::OnBeforeConnect [this=000001E005A07000 willCallback=0 rv=0]
2021-01-15 10:29:12.621000 UTC - [Parent 6872: Main Thread]: V/nsHttp nsHttpChannel::MaybeUseHTTPSRRForUpgrade [000001E005A07000] wait for HTTPS RR

Comment 13

[Kershaw Chang [:kershaw]]

Attachment: Bug 1686828 - Handle the case that we have an empty https rr before deciding whether to do https upgrade

Comment 14

[Kershaw Chang [:kershaw]]

Attachment: Bug 1686828 - Use https OriginAttributes to fetch HTTPS RR

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e83b6fb52b62
Handle the case that we have an empty https rr before deciding whether to do https upgrade r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/1a38b75a7dbb
Use https OriginAttributes to fetch HTTPS RR r=necko-reviewers,timhuang,dragana

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e83b6fb52b62
https://hg.mozilla.org/mozilla-central/rev/1a38b75a7dbb

Comment 17

[Loïc Yhuel]

The issue is now fixed, with the latest nightly and network.dns.upgrade_with_https_rr=true everything loads correctly.

Comment 18

[Kershaw Chang [:kershaw]]

(In reply to Loïc Yhuel from comment #17)

The issue is now fixed, with the latest nightly and network.dns.upgrade_with_https_rr=true everything loads correctly.

Thanks for testing.