1688945 - Crash in [@ mozilla::net::nsHttpChannel::OnHTTPSRRAvailable]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

3 crashes (diagnostic asserts) on 1 machine, regression from bug 1686828?

Crash report: https://crash-stats.mozilla.org/report/index/8eded45c-ffe4-49fa-8b0d-a97bb0210126

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(!isSome())

Top 10 frames of crashing thread:

0 xul.dll mozilla::net::nsHttpChannel::OnHTTPSRRAvailable netwerk/protocol/http/nsHttpChannel.cpp:9043
1 xul.dll std::_Func_impl_no_alloc<`lambda at /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:6846:11', void, nsIDNSHTTPSSVCRecord*>::_Do_call 
2 xul.dll `anonymous namespace'::HTTPSRRListener::OnLookupComplete netwerk/base/nsDNSPrefetch.cpp:119
3 xul.dll mozilla::detail::RunnableFunction<`lambda at /builds/worker/checkouts/gecko/netwerk/dns/DNSListenerProxy.cpp:28:30'>::Run xpcom/threads/nsThreadUtils.h:534
4 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:741
5 xul.dll mozilla::detail::RunnableFunction<`lambda at /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:123:7'>::Run xpcom/threads/nsThreadUtils.h:534
6 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1200
7 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:87
8 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:327
9 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:309

Comment 1

[Kershaw Chang [:kershaw]]

This could be caused by network.dns.use_https_rr_for_speculative_connection is enabled. If this pref is true, we always query HTTPS RR no mater if we already have mHTTPSSVCRecord or not.

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1688945 - Make sure we don't query HTTPS RR when we already have one

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4309b577f25a
Make sure we don't query HTTPS RR when we already have one r=necko-reviewers,valentin

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4309b577f25a

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kershaw, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Kershaw Chang [:kershaw]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #5)

The patch landed in nightly and beta is affected.
:kershaw, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

No need to uplift, since this crash is only happened when some non-default prefs are enabled.