Closed
Bug 1686846
Opened 5 years ago
Closed 5 years ago
Consider merging cache/alloc for initial and delazifications in CompilationStencilSet
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
86 Branch
Tracking | Status | |
---|---|---|
firefox86 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
after bug 1683276, CompilationStencilSet
doesn't contain separate field for initial stencil,
and now both CompilationAtomCache
in input
and LifoAlloc
are placed above delazifications in the struct hierarchy.
we could remove delazificationAtomCache
and allocForDelazifications
and share
CompilationStencil.input.atomCache
and CompilationStencil.alloc
.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
Use CompilationStencil.input.alloc instead.
Depends on D102708
Assignee | ||
Comment 2•5 years ago
|
||
Use CompilationStencil.input.atomCache instead, with reserving the maximum size
across initial+delazification beforehand, and reusing the same buffer across
initial+delazification during instantiation.
Depends on D102709
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/e3e5f2862dbe
Part 1: Remove CompilationStencilSet.allocForDelazifications. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/04de6f0a6a4c
Part 2: Remove CompilationStencilSet.delazificationAtomCache. r=tcampbell
![]() |
||
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e3e5f2862dbe
https://hg.mozilla.org/mozilla-central/rev/04de6f0a6a4c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•