Closed Bug 1686929 Opened 4 years ago Closed 4 years ago

[Proton] Only show "Inspect Accessibility Properties" context menu item if the user has opened devtools at least once

Categories

(Firefox :: Menus, enhancement, P1)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox88 --- verified

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-context-menus])

Attachments

(1 file)

Right now there are 2 "Inspect" items in the context menu. By default, we should only show one, and we should only show the other one if users actually use the "inspect" item that's there, as most users won't use either.

Severity: -- → N/A
Type: defect → enhancement
Priority: -- → P3

From Matrix:
We should add method to DevToolsShim (used in nsContextMenu) that simply calls and returns DevToolsStartup.isDevToolsUser

DevToolsShim.isDevToolsUser would be an additional check (or replace some of the prefs) when checking to build the context menu item for a11y inspection.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Blocks: 1692628

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Priority: P3 → P1
Attachment #9203006 - Attachment description: Bug 1686929 - only show the inspect a11y properties menuitem for devtools users, r?yzen → Bug 1686929 - only show the inspect a11y properties menuitem for devtools users, r?jdescottes
See Also: → 1695257
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6b2d3a1aea51 only show the inspect a11y properties menuitem for devtools users, r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Verified that this works as expected in latest Nightly across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: