1686931 - Unify "View Background Image" with "View Image"

Status: VERIFIED FIXED

(Firefox :: Menus, enhancement, P1)

Description

[:Gijs (he/him)]

If you e.g. open about:blank, and open the context menu on it, we show this item (disabled).

We should just not show it. There isn't a background image; the item makes no sense.

Comment 1

[Neil Deakin]

Going to look at doing this. I assume the idea is to remove "View Background Image" and just use "View Image" instead.

Comment 2

[Neil Deakin]

Attachment: Bug 1686931, combine the view image and background image commands on the content area context menu

Comment 3

[Neil Deakin]

I added a basic implementation that removes "View Background Image" and uses the existing "View Image". Some UI notes that warrant further discussion or investigation:

While the user wouldn't likely understand the difference between the two, some commands don't work on background images. (copy image, save image, set as background, view image info)

This leads to context menus that for an <img> becomes:

View Image
Copy Image
Copy Image Location

Save Image As...
Email Image
Set As Desktop Background...
View Image Info
...

The context menu for an element with a background image is:

View Image
Copy Image Location

Email Image
Save Page to Pocket...

Send Page To Device...
Select All
...

"Email Image" here is grouped with save page rather than the other image commands. Also, this context menu shows other commands such as "Select All" that are currently available for background images but not regular images.

Another source of confusion: go to planet.mozilla.org and scroll all the way to the bottom of the page. The context menu here includes background image commands yet to the user the image is nowhere to be seen as it's only visible at the top of the page.

Comment 4

[Neil Deakin]

Attachment: Bug 1686931, merge view image and view background image commands on context menu, r=gijs

Depends on D103774

Comment 5

[Blake Winton (:bwinton) (:☕️)]

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/226b92328b52
merge view image and view background image commands on context menu, r=Gijs

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/226b92328b52

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 9

[Bogdan Maris, Desktop Test Engineering]

Verified that View Background Image does no longer exist in context menu and with bug 1690030, View Image is now Open Image in new tab. Also verified that Open Image in new tab functionality is not affected by this across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04).