Closed Bug 1691860 Opened 3 years ago Closed 3 years ago

Make context menu separator hiding more robust

Categories

(Firefox :: Menus, task, P1)

Product:
Firefox
Component:
Menus
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

(Whiteboard: [proton-context-menus])

Attachments

(1 file)

Bug 1691860, move code that hides separators in the content area context menu into a single place that just hides duplicates, r=gijs, robwu
48 bytes, text/x-phabricator-request
Details | Review

While working with the content area context menus (nsContextMenu.js), I've found it difficult to ensure that each separator is shown or hidden properly when different combinations of menuitems are shown. Instead I propose just hiding any duplicated separators after all the items have been determined.

The patch to be attached does this with minimal differences in the separators that are displayed, mostly showing current places on the menu (such as before select all) where unrelated items seem to be placed together.

The proton changes will likely change the menus around quite a bit anyway, so I suspect we can adjust the separator handling better as we go.

Summary: Make context menu separator hiding more → Make context menu separator hiding more robust
Blocks: 1692666
Whiteboard: [proton-context-menus]
Severity: -- → N/A
Type: enhancement → task
Priority: -- → P1

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Blocks: 1693954

The Bugbug bot thinks this bug should belong to the 'Firefox::Menus' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: General → Menus
Attachment #9202218 - Attachment description: Bug 1691860, move code that hides separators in the content area context menu into a single place that just hides duplicates, r=gijs → Bug 1691860, move code that hides separators in the content area context menu into a single place that just hides duplicates, r=gijs, robwu
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/873822e54461
move code that hides separators in the content area context menu into a single place that just hides duplicates, r=Gijs,robwu

https://hg.mozilla.org/mozilla-central/rev/873822e54461

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Regressions: 1696450
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: