1686938 - Crash in [@ mozilla::ClearSiteData::Observe]

Status: RESOLVED FIXED

(Core :: Storage: StorageManager, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Steps to reproduce:

1. Open https://stackoverflow.com/questions/11178673/how-to-override-important
2. Go to the answer which starts with "Disclaimer: Avoid !important at all cost."
3. Click the button "Run code snippet".

Sheriffs will back out bug 1685355 and request new Nightlies.

Crash report: https://crash-stats.mozilla.org/report/index/b8f2681c-ce20-421b-8029-1797f0210115

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll mozilla::ClearSiteData::Observe toolkit/components/clearsitedata/ClearSiteData.cpp:145
1 xul.dll nsObserverList::NotifyObservers xpcom/ds/nsObserverList.cpp:70
2 xul.dll nsObserverService::NotifyObservers xpcom/ds/nsObserverService.cpp:287
3 xul.dll mozilla::net::nsHttpHandler::NotifyObservers netwerk/protocol/http/nsHttpHandler.cpp:873
4 xul.dll mozilla::net::nsHttpChannel::OnStartRequest netwerk/protocol/http/nsHttpChannel.cpp:7458
5 xul.dll nsInputStreamPump::OnInputStreamReady netwerk/base/nsInputStreamPump.cpp:390
6 xul.dll nsInputStreamReadyEvent::Run xpcom/io/nsStreamUtils.cpp:94
7 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:739
8 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1200
9 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:87

Comment 1

[Clemens Eisserer]

Happens with the following URL without any user interaction:

https://www.amazon.de/s?k=programming+vulkan&__mk_de_DE=%C3%85M%C3%85%C5%BD%C3%95%C3%91&ref=nb_sb_noss

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

Fixed by the backout of bug 1685355

Comment 3

[Paul Zühlcke [:pbz]]

Thanks for handling this so quickly!
Here is what led to the crash: https://bugzilla.mozilla.org/show_bug.cgi?id=1685355#c5