1687314 - Investigate how to handle NullPrincipal in StoragePrincipalHelper::Create

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P3)

Description

[Emma Zühlcke [:emz]]

If we get a NullPrincipal in StoragePrincipalHelper::Create the call to clone the principal here: https://searchfox.org/mozilla-central/rev/dac45cc7020dfddbcc937827810dd11550c07dc3/toolkit/components/antitracking/StoragePrincipalHelper.cpp#109-110 will return a nullptr. It doesn't set any error code for this case.

This is returned by getChannelResultStoragePrincipal: https://searchfox.org/mozilla-central/rev/dac45cc7020dfddbcc937827810dd11550c07dc3/caps/nsIScriptSecurityManager.idl#231

The behavior is a bit unexpected, because getChannelResultPrincipal will return the NullPrincipal instead of a nullptr.
We should investigate how to handle NullPrincipal and try to align the behavior.

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1687314 - Improve behavior of GetChannelResultStoragePrincipal and StoragePrincipalHelper::Create when handling NullPrincipal. r=timhuang!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fef56f826d64
Improve behavior of GetChannelResultStoragePrincipal and StoragePrincipalHelper::Create when handling NullPrincipal. r=timhuang

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fef56f826d64