1687116 - [Windows][Linux] About Firefox "Firefox Help" and "Submit Feedback" links do nothing

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Asif Youssuff]

Attachment: Screenshot from 2021-01-16 11-06-29.png

The links in the Firefox about dialog "Firefox Help" and "Submit Feedback" do nothing.

22:39.26 INFO: No more integration revisions, bisection finished.
22:39.26 INFO: Last good revision: a673fcbd7a067815aa8b8966e134283aae5a4e56
22:39.26 INFO: First bad revision: b1628ddad29124227e334e82e9fac863bc877e4d
22:39.26 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a673fcbd7a067815aa8b8966e134283aae5a4e56&tochange=b1628ddad29124227e334e82e9fac863bc877e4d

Comment 1

[:Gijs (out for now; he/him)]

WFM on macOS. Is this Windows-specific?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Can reproduce on Windows. From browser console:

18:48:27.861 Uncaught ReferenceError: openHelpLink is not defined
    onclick chrome://browser/content/aboutDialog.xhtml:1
aboutDialog.xhtml:1:1

Comment 3

[:Gijs (out for now; he/him)]

The openHelpLink and openFeedbackPage functions are defined in utilityOverlay.js, which is only loaded in the about dialog on macOS (courtesy of macWindow.inc.xhtml). We should also load that script on non-mac if we want to use these functions, probably by adding an else block to https://searchfox.org/mozilla-central/rev/361d3e3a61929bb3fc4f088adf97649e38900f00/browser/base/content/aboutDialog.xhtml#33-35 . Bernard, can you take a look the coming week? Thanks!

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1660848

Comment 5

[Sylvestre Ledru [:Sylvestre]]

And on Mac, the "submit feedback" link is pointing to a link thanking me for having answered to the form (even if I didn't enter anything)

Comment 6

[:Gijs (out for now; he/him)]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #5)

And on Mac, the "submit feedback" link is pointing to a link thanking me for having answered to the form (even if I didn't enter anything)

I cannot reproduce this, I get https://qsurvey.mozilla.com/s3/Give-feedback-landing-page which says "Please check back soon". This is the same helper that is used in Help > Submit Feedback..., so any issues with that page (maybe the French translation has not been updated?) should be filed as separate bugs.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Attachment: image.png

Same URL indeed but I see that (in French en effet ;)

Comment 8

[:Gijs (out for now; he/him)]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #7)

Created attachment 9198155 [details]
image.png

Same URL indeed but I see that (in French en effet ;)

Right. Please file a separate bug; it's not a bug introduced by the check for updates menuitem / the changes to the about dialog (as the link was already accessible through Help > submit feedback), and it cannot be fixed here - it'll need content changes on the French version of that site.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Done in bug 1687695

Maybe don't show the "Submit feedback" in the about Windows until the form is ready?

Comment 10

[:Gijs (out for now; he/him)]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #9)

Done in bug 1687695

Maybe don't show the "Submit feedback" in the about Windows until the form is ready?

Markus, what's the rationale for showing this link in the first place? Should we just remove it as it doesn't go anywhere useful?

Comment 11

[Markus Jaritz [:designakt] (UX)]

(In reply to :Gijs (he/him) from comment #10)

(In reply to Sylvestre Ledru [:Sylvestre] from comment #9)

Maybe don't show the "Submit feedback" in the about Windows until the form is ready?

Markus, what's the rationale for showing this link in the first place? Should we just remove it as it doesn't go anywhere useful?

as long as we don't take in feedback I agree, we shouldn't show this button. Shouldn't show it in the help menu either.

why it's shown there is that people often look for updates if they have a problem - so giving them ways to do something about that in that context can give them a way forward.

Comment 12

[Mike Hoye [:mhoye]]

Please don't pull any buttons pointing to input.mozilla.org out of our products! They're going to point to a new home shortly, and we're finalizing that now.

We will eventually need to update the URLs, but that is a different thing. For the moment, I will ask that you bear with me while we get some contracts and deployment sorted out, those buttons will eventually be pointing at a new community feedback and participation forum. We're overdue on deploying it, because contracts and [gestures vaguely at the whole world] but it's on the way.

Comment 13

[:Gijs (out for now; he/him)]

(In reply to Mike Hoye [:mhoye] from comment #12)

Please don't pull any buttons pointing to input.mozilla.org out of our products! They're going to point to a new home shortly, and we're finalizing that now.

We will eventually need to update the URLs, but that is a different thing. For the moment, I will ask that you bear with me while we get some contracts and deployment sorted out, those buttons will eventually be pointing at a new community feedback and participation forum. We're overdue on deploying it, because contracts and [gestures vaguely at the whole world] but it's on the way.

I think that's fine, but I don't think we should be adding new buttons that point somewhere useless. We can unhide / add those buttons once the new thing exists.

Comment 14

[Mike Hoye [:mhoye]]

We are less-than-weeks from having this service stood up, and finalizing the contract now.

Comment 15

[Bernard Igiri]

Attachment: Bug 1687116 - Enabling Help and Feedback links in Windows and Linux in the About Dialog. r=gijs,mconley

Enabling help and feedback links in Windows and Linux by making sure the functions for these are available in the About dialog in Windows and Linux builds.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/313bbb0138e6
Enabling Help and Feedback links in Windows and Linux in the About Dialog. r=Gijs

Comment 17

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/313bbb0138e6