1687213 - "About Firefox" dialog now has two side-by-side links with no separation ("Firefox Help Submit Feedback") which feels a bit jumbled/awkward

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: image.png

The "About Firefox" dialog changed its content a little in bug 1660848, and now it has a line with two side-by-side links: Firefox Help Submit Feedback. See attached screenshot.

These links feel a little jumbled - in particular:

• They don't have any separation between them (besides a space character) which makes it hard to see where one link stops and the next begins. Especially because the "p" interrupts the first link's underline.
• The rest of the dialog (after this point) is all either complete sentences ("You are currently on the nightly update channel."), so this one line of four random words ("Firefox Help Submit Feedback") feels a little weird/jumpy.

I'm not a designer, and I don't know what best practices are for this sort of thing; but I wonder if maybe we should add a little more space between these links? As an example of a piece of this UI that's got similar content but feels cleaner see the very bottom of the dialog where we have a link bar, which says "Licensing Information" [lots of space] "End-User Rights" [lots of space] "Privacy Policy". The spacing there makes the links easier to distinguish and prevents them from feeling like a weird sentence fragment.

Comment 1

[Daniel Holbert [:dholbert]]

(Sorry, I initially had mis-linked bug 1687116 as the bug where stuff had changed; fixed now. I meant to link this to bug 1660848.)

Comment 2

[Markus Jaritz [:designakt] (UX)]

Attachment: About Firefox Layout

(In reply to Daniel Holbert [:dholbert] from comment #0)

The "About Firefox" dialog changed its content a little in bug 1660848, and now it has a line with two side-by-side links: Firefox Help Submit Feedback. See attached screenshot.
I'm not a designer, and I don't know what best practices are for this sort of thing; but I wonder if maybe we should add a little more space between these links?

I agree spacing can make this much more readable. Space not just between the links, but also separating it from the previous line which is thematically more linked to the update status line then to the "how to get help"-links.
See attached a proposed layout to improve readability.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hey Bernard, do you think you have time to look at this?

Comment 4

[Bernard Igiri]

Attachment: Bug 1687213 - Increase spacing between About Firefox and Submit Feedback links. r=flod,mconley

Increase spacing bewtween About Firefox and Submit Feedback links and addint the elipsis character to the end of the Submit Feedback link.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9570bc664bb0
Increase spacing between About Firefox and Submit Feedback links. r=Gijs

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9570bc664bb0

Comment 7

[Daniel Holbert [:dholbert]]

Attachment: screenshot of fixed rendering (with patch)

Confirmed that this looks fixed, on my end (screenshot attached, just for fun).

Thanks for the quick action!