1687153 - Search keyword is not consistent with localized Wikipedia search engine name

Status: RESOLVED FIXED

(Firefox :: Search, defect, P3)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

The Wikipedia has a search keyword @wikipedia in Firefox, however in Czech the name is Wikipedie (see the logo in the top left https://cs.wikipedia.org/wiki/Hlavn%C3%AD_strana) and so the keyword should match the name.

Comment 1

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Flod, are the keywords hardcoded, or can they be changed per locale, please?

Also I noticed not all search engines that ship with Czech Firefox by default have keyword configured by default. Is that desired to have the keywords only for the most prominent engines, or shall we provide keywords for all engines?

Comment 2

[Francesco Lodolo [:flod]]

As far as I know, they're hard-coded. Not sure if Mark knows more about them, and if the issue was already considered, or can redirect the question.

Comment 3

[Mark Banner (:standard8)]

I just checked, we'd be alright to add localised versions for Wikipedia.

I think the best way would be to change the keyword definition into an array, which contains a string that we localise per locale in a similar way to the name, and the standard English string.

We'd need a small fix to de-dupe the aliases for the English locale, but otherwise I think that would work.

Comment 4

[Dale Harvey (:daleharvey)]

We cant translate https://searchfox.org/mozilla-central/source/browser/components/search/extensions/ddg/manifest.json#20 directly. may need to turn into comma seperate string

Comment 5

[Mark Banner (:standard8)]

We're going to look at fixing this just after, or maybe as part of, our search configuration redesign work.

Comment 6

[Mark Banner (:standard8)]

For all the Wikipedias it seems it would be reasonable to end up with:

• A keyword for the English name wikipedia
• Where different: a keyword for the localised name

The localised keyword one should come first and then the English keyword.

Comment 7

[Moritz Beier [:mbeier]]

Attachment: Bug 1687153 - Search keyword is not consistent with localized Wikipedia search engine name. r?standard8

Comment 8

[Moritz Beier [:mbeier]]

Attachment: Bug 1687153 - Prepare test_wikipedia.js for localized Wikipedia keywords. r?standard8

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a906f94fdf75
Prepare test_wikipedia.js for localized Wikipedia keywords. r=Standard8

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a906f94fdf75

Comment 11

[Moritz Beier [:mbeier]]

Attachment: Bug 1687153 - Prepare test_wikipedia.js for localized Wikipedia keywords. r?standard8

Original Revision: https://phabricator.services.mozilla.com/D224218

Comment 12

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Needed for new remote settings config, otherwise this test will fail.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: only changes in a test
• String changes made/needed: no
• Is Android affected?: no

Comment 13

[Moritz Beier [:mbeier]]

Attachment: Bug 1687153 - Prepare test_wikipedia.js for localized Wikipedia keywords. r?standard8

Original Revision: https://phabricator.services.mozilla.com/D224218

Comment 14

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Needed for new remote settings config, otherwise this test will fail.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: only changes a test
• String changes made/needed: no
• Is Android affected?: no

Comment 15

[Moritz Beier [:mbeier]]

Attachment: Bug 1687153 - Prepare test_wikipedia.js for localized Wikipedia keywords. r?standard8

Original Revision: https://phabricator.services.mozilla.com/D224218

Comment 16

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Needed for new remote settings config, otherwise this test will fail.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: only changes a test
• String changes made/needed: no
• Is Android affected?: no

Comment 17

[Moritz Beier [:mbeier]]

The updated config is on staging now. It should add the localized keywords to all locales where the local name is not Wikipedia (e.g. typing @wikipedie in the urlbar in cs locale should set the searchmode to Wikipedia). It should also work with RTL locales and the english @wikipedia should still work for all locales.

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7cefdf5f95bc

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/ecb2548d698c

Comment 20

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/15fc1d022fdb

Comment 21

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: wikipedia english alias duplicate.png

The issue is verified fixed using Fx 133.0a1, Fx 132.0b5, Fx 131.0.2 and Fx 128.3.1ESR on Windows 11, Ubuntu 24 and macOS with RS set to Staging.
Wikipedia searchmode is correctly launched when inputing the localized alias or the english alias of the engine. The testing results can be viewed here.

A note worthy of mention here is that the BE locale has 2 wikipedia engines localized in be and be-tarask. Typing the localized string has no issue and launches the correct and expected wikipedia searchmode. Problem arises with the obvious conflict, both engines have the english alias and when typing @wikipedia launches the be-tarask wikipedia searchmode.

Comment 22

[Moritz Beier [:mbeier]]

Thank you very much for checking this. I removed the @wikipedia alias from be-tarask and the changes are now on staging (in review). Mark suggested this since the user can still edit the aliases.

Comment 23

[Cristian Baica [:cbaica], Release Desktop QA]

Confirming that be-tarask no longer has the @wikipedia alias, but the localized alias for be-tarask still works and now the @wikipedia correctly goes in the BE locale wikipedia searchmode.

From a QA standpoint this is ready for PROD push.

Comment 24

[Moritz Beier [:mbeier]]

Thanks, the changes are now on production.