1687153 - Search keyword is not consistent with localized Wikipedia search engine name

Status: NEW

(Firefox :: Search, defect, P3)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

The Wikipedia has a search keyword @wikipedia in Firefox, however in Czech the name is Wikipedie (see the logo in the top left https://cs.wikipedia.org/wiki/Hlavn%C3%AD_strana) and so the keyword should match the name.

Comment 1

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Flod, are the keywords hardcoded, or can they be changed per locale, please?

Also I noticed not all search engines that ship with Czech Firefox by default have keyword configured by default. Is that desired to have the keywords only for the most prominent engines, or shall we provide keywords for all engines?

Comment 2

[Francesco Lodolo [:flod]]

As far as I know, they're hard-coded. Not sure if Mark knows more about them, and if the issue was already considered, or can redirect the question.

Comment 3

[Mark Banner (:standard8)]

I just checked, we'd be alright to add localised versions for Wikipedia.

I think the best way would be to change the keyword definition into an array, which contains a string that we localise per locale in a similar way to the name, and the standard English string.

We'd need a small fix to de-dupe the aliases for the English locale, but otherwise I think that would work.

Comment 4

[Dale Harvey (:daleharvey)]

We cant translate https://searchfox.org/mozilla-central/source/browser/components/search/extensions/ddg/manifest.json#20 directly. may need to turn into comma seperate string

Comment 5

[Mark Banner (:standard8)]

We're going to look at fixing this just after, or maybe as part of, our search configuration redesign work.