1687207 - MessageSend.jsm causes unnecessary loading of modules on startup

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Mark Banner (:standard8)]

MessageSend.jsm is loaded very early in startup, as it is not lazy loading its modules, it causes various other javascript modules to be loaded early than necessary.

On my machine with an SSD drive, it takes ~11ms to load all of these, on a HDD that is likely to be longer.

Things like:

var { OS } = ChromeUtils.import("resource://gre/modules/osfile.jsm");

Should be using:

const { XPCOMUtils } = ChromeUtils.import(
  "resource://gre/modules/XPCOMUtils.jsm"
);

XPCOMUtils.defineLazyModuleGetters(this, {
  OS: "resource://gre/modules/osfile.jsm",
});

https://searchfox.org/comm-central/rev/e5bad7edc0e9cdb1e02f040ac5a2a60b984e9b6f/mailnews/addrbook/modules/AddrBookManager.jsm#7-18

or at worst, ChromeUtils.defineModuleGetter.

If things are needed straight away (e.g. XPCOMUtils in the example above), they can be directly imported, otherwise we should be lazy loading to help our startup times.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: 1687207.patch

Use defineLazyModuleGetters in MessageSend.jsm and SmtpService.jsm.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9197675 [details] [diff] [review]
1687207.patch

Review of attachment 9197675 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Services is always going to be there so could potentially just be outside. But I don't think it matters much.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cf4074b0e9f3
Use defineLazyModuleGetters in MessageSend.jsm and SmtpService.jsm. r=mkmelin