Closed Bug 1687365 Opened 3 years ago Closed 2 years ago

Many Touch Bar-related errors logged when windows are opened while using Big Sur

Categories

(Core :: Widget: Cocoa, defect, P3)

Desktop
macOS
defect

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: bugzilla, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [mac:developer])

When Firefox starts on Big Sur, the following errors are logged:

2021-01-18 14:34:24.987 firefox[20118:426336] Warning: Expected min height of view: (<NSButton: 0x13340ac00>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.
2021-01-18 14:34:24.988 firefox[20118:426336] Warning: Expected min height of view: (<NSButton: 0x1336d4400>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.
2021-01-18 14:34:24.989 firefox[20118:426336] Warning: Expected min height of view: (<NSButton: 0x1336d0800>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.
2021-01-18 14:34:24.989 firefox[20118:426336] Warning: Expected min height of view: (<NSButton: 0x1336d5c00>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.
2021-01-18 14:34:24.990 firefox[20118:426336] Warning: Expected min height of view: (<NSButton: 0x1336d2800>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.
2021-01-18 14:34:24.990 firefox[20118:426336] Warning: Expected min height of view: (<NSPopoverTouchBarItemButton: 0x1336d3800>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.
2021-01-18 14:34:24.991 firefox[20118:426336] Warning: Expected min height of view: (<NSPopoverTouchBarItemButton: 0x1336dcc00>) to be less than or equal to 30 but got a height of 32.000000. This error will be logged once per view in violation.

This appears to be a problem for other apps that use the Touch Bar when they are built with an SDK less than the macOS 11 SDK: See this MacVim GitHub issue (resolution) and a thread about the Mac version of R.

OS: Unspecified → macOS
Hardware: Unspecified → Desktop
Summary: Many Touch Bar-related errors logged on startup → Many Touch Bar-related errors logged on startup when using Big Sur

Oh, it's because of the SDK! That makes sense.

Depends on: 1670751
Priority: -- → P3
Summary: Many Touch Bar-related errors logged on startup when using Big Sur → Many Touch Bar-related errors logged when windows are opened while using Big Sur

Is there some way we can hide these messages or only log them in debug builds? They are really spammy and it makes it difficult to spot other things being logged.

Flags: needinfo?(spohl.mozilla.bugs)
Flags: needinfo?(mstange.moz)

To avoid the messages in your own builds, you could build with the macOS 11 SDK locally.

Flags: needinfo?(spohl.mozilla.bugs)
Flags: needinfo?(mstange.moz)

I'm not sure if it's possible to hide those messages. I think the best fix is to move to the macOS 11 SDK and make it the required minimum SDK. We're currently looking at doing that somewhat soonish.

(In reply to Markus Stange [:mstange] from comment #3)

To avoid the messages in your own builds, you could build with the macOS 11 SDK locally.

That means not using artifact builds which would significantly slow down my work.

Ah, I missed that.

I found https://scottberrevoets.com/2016/08/01/silencing-nslog/ which could help here.

Whiteboard: [mac:developer]
Depends on: 1696504
No longer depends on: 1670751

Looks like this is solved with the new SDK.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Reopening because bug 1696504 got backed out.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Resolving because bug 1696504 got relanded.

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.