Open Bug 1696504 Opened 11 months ago Updated 6 days ago

Build Firefox with the macOS 11 SDK in CI

Categories

(Core :: Widget: Cocoa, task, P3)

All
macOS
task

Tracking

()

REOPENED

People

(Reporter: mstange, Assigned: glandium)

References

(Depends on 2 open bugs, Blocks 3 open bugs, Regressed 1 open bug)

Details

(Keywords: perf-alert)

Attachments

(1 file)

We currently use the macOS 11 SDK in CI for arm64 Firefox builds, but we're still using the 10.12 SDK for x86_64 Firefox builds. We should use the macOS 11 SDK for both.

This will have the following benefits:

  • It will avoid compatibility paths in macOS system libraries and get us on the "happy path". Apple expects apps to adopt new SDKs somewhat quickly. Building with an older SDK enables runtime behaviors in macOS system libraries that don't receive a lot of testing from Apple. We've seen various amounts of breakage in the compatibility paths when new versions of macOS were released. (The most striking one was a crash after sleep when touch bar macs were originally released, bug 1320048. This only happened on apps built with an older SDK.)
  • As an example of the above, updating to the macOS 11 SDK will avoid spammy touch bar related warnings that are currently printed to the console whenever a Firefox window is opened (bug 1687365).
  • It is a necessary prerequisite for raising our minimum supported SDK version to the macOS 11 SDK (bug 1696513), which will improve the quality of life for Firefox developers on macOS.
Blocks: 1687365
Type: defect → task
Blocks: 1696513
Priority: -- → P3
Depends on: 1733508
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/a899281204c7
Bump macOS builds to SDK 11.0. r=firefox-build-system-reviewers,mhentges

Backed out changeset a899281204c7 (Bug 1696504) for causing GTest failures.
Backout link
Push with failures
Failure Log

Flags: needinfo?(mh+mozilla)
Depends on: 1703554
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/572b175efb09
Bump macOS builds to SDK 11.0. r=firefox-build-system-reviewers,mhentges
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
See Also: → 1742150
Regressions: 1743133
Regressions: 1743409
Regressions: 1742877
Depends on: 1742877
Depends on: 1743133
Depends on: 1743409
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 96 Branch → ---
Flags: needinfo?(mh+mozilla)

The regression bugs have been changed to dependent bugs we will have to fix before re-landing this.

Flags: needinfo?(mh+mozilla)

(In reply to Sandor Molnar from comment #6)

Backed out for causing regressions.

Backout link: https://hg.mozilla.org/mozilla-central/rev/b1571319e4cdb9e3ae3f024bd3a4921a53da7b76

== Change summary for alert #32610 (as of Fri, 03 Dec 2021 18:51:30 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
8% Heap Unclassified macosx1015-64-shippable-qr tp6 135,159,397.78 -> 124,175,483.62
7% Heap Unclassified macosx1015-64-shippable-qr tp6 134,191,528.53 -> 124,575,927.96

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32610

Keywords: perf-alert

(In reply to Sandor Molnar from comment #6)

Backed out for causing regressions.

Backout link: https://hg.mozilla.org/mozilla-central/rev/b1571319e4cdb9e3ae3f024bd3a4921a53da7b76

== Change summary for alert #32641 (as of Mon, 06 Dec 2021 12:45:59 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
28% ts_paint_webext macosx1015-64-shippable-qr e10s stylo webrender-sw 725.58 -> 521.17
28% ts_paint macosx1015-64-shippable-qr e10s stylo webrender-sw 722.92 -> 520.42
26% sessionrestore macosx1015-64-shippable-qr e10s stylo webrender-sw 755.58 -> 555.92
26% sessionrestore_many_windows macosx1015-64-shippable-qr e10s stylo webrender-sw 741.67 -> 546.50
25% sessionrestore_no_auto_restore macosx1015-64-shippable-qr e10s stylo webrender-sw 779.92 -> 587.33
... ... ... ... ...
17% startup_about_home_paint_realworld_webextensions macosx1015-64-shippable-qr e10s fission stylo webrender 1,157.58 -> 957.58

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32641

No longer regressions: 1742877
No longer regressions: 1743133
No longer regressions: 1743409
Regressions: 1743170

(In reply to Andrej (:andrej) from comment #8)

(In reply to Sandor Molnar from comment #6)

Backed out for causing regressions.

Backout link: https://hg.mozilla.org/mozilla-central/rev/b1571319e4cdb9e3ae3f024bd3a4921a53da7b76

== Change summary for alert #32610 (as of Fri, 03 Dec 2021 18:51:30 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
8% Heap Unclassified macosx1015-64-shippable-qr tp6 135,159,397.78 -> 124,175,483.62
7% Heap Unclassified macosx1015-64-shippable-qr tp6 134,191,528.53 -> 124,575,927.96

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32610

== Change summary for alert #32613 (as of Fri, 03 Dec 2021 19:19:50 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
11% bing-search FirstVisualChange macosx1015-64-shippable-qr cold webrender 395.00 -> 353.33
10% bing-search FirstVisualChange macosx1015-64-shippable-qr cold fission webrender 405.00 -> 363.33
10% bing-search ContentfulSpeedIndex macosx1015-64-shippable-qr cold fission webrender 443.04 -> 399.67
9% bing-search ContentfulSpeedIndex macosx1015-64-shippable-qr cold webrender 437.62 -> 400.42
7% amazon ContentfulSpeedIndex macosx1015-64-shippable-qr cold fission webrender 540.75 -> 503.25
... ... ... ... ...
6% amazon ContentfulSpeedIndex macosx1015-64-shippable-qr cold webrender 532.83 -> 502.17

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32613

Blocks: 1727624
No longer blocks: 1679927
You need to log in before you can comment on or make changes to this bug.