1687397 - Drop the fade in and out effect on the microphone/camera icons in the URL bar when sharing WebRTC streams

Status: VERIFIED FIXED

(Firefox :: Site Permissions, task, P2)

Description

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

This icon is used to tell users that they're sharing a video or audio stream to the site. The fade-in and out effect almost suggests that the icon can be interacted with, but it can't.

Product suggests we drop the fade-in and fade-out effect entirely.

For comparison, while Chromium browsers and Safari show a red recording icon for sharing devices, those icons do not fade-in or fade-out.

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Hey johannh, any PrivSec objections to removing this effect?

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Technically speaking, removing this effect is very straight-forward. It's a matter of removing these lines:

• https://searchfox.org/mozilla-central/rev/85f20360d898501f0fac12dd35fe8b7475e01848/browser/themes/shared/identity-block/identity-block.inc.css#211
• https://searchfox.org/mozilla-central/rev/85f20360d898501f0fac12dd35fe8b7475e01848/browser/themes/shared/identity-block/identity-block.inc.css#216-218

Comment 3

[Johann Hofmann [:johannh]]

So while I personally greatly prefer the effect because it makes the icon more noticeable, I wouldn't stand in the way of removing it. You need to figure out what to do for tab icons, where it currently uses the fade to switch between sharing icon and favicon.

Comment 4

[Marco Bonardo [:mak]]

I create a Jira Spike to answer the tab icon question.

Comment 5

[Marco Bonardo [:mak]]

Attachment: Bug 1687397 - Don't flash the microphone/camera icon during WebRTC in the identity panel. r=dao

Comment 6

[Marco Bonardo [:mak]]

I don't yet have an answer about tabs, I'll wait for it, but it can (and probably should) easily become a separate bug.
Actually since now tabs have a status line (for "playing") we could similarly use that line for sharing Cam/Mic

Comment 7

[Marco Bonardo [:mak]]

I filed bug 1693254 for the tabs work, since it's blocked by missing a spec. So we can proceed with this.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13611f85c448
Don't flash the microphone/camera icon during WebRTC in the identity panel. r=dao

Comment 9

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/13611f85c448

Comment 10

[Cristian Comorasu, QA [:ccomorasu], Release Desktop QA]

We verified this issue using Fx 88.0b5 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 LTS.