1687681 - [FR][ebay.fr] Expiry date autofill incorrect format

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Alin Ilea]

Attachment: 2021-01-20_11h55_38.mp4

Affected Versions:

All latest Firefox versions using force enable (Nightly 86, Beta RC 85.0, Release 84.0.2)

Tested on:

Windows 10 x64

Prerequisites:

browser.search.region FR
extensions.formautofill.supportedCountries FR
download latest Firefox Nightly with region locale (switch extensions.formautofill.available to "on" for testing non-Nightly builds)

Steps to Reproduce:

1. Launch Firefox
2. Go to and reach the payment form for ebay.fr
3. Using autofill feature, select 1 saved CC entry

Expected Results:

Expiry Date should be displayed accordingly like when the user hover over the date from the autofill drop-down.

Actual Results:

Expiry Date incorrect format.

Notes:

Severity: S4 since the issue seems to be ebay.fr specific. It is not reproducible on ebay.com or ebay.ca
Reproducible on Chrome?: No
Regression-range: reproducible on all latest versions, this site was never tested before, can look for regression-range if need be.

Comment 1

[Tim Giles [:tgiles]]

The issue appears to be because of the placeholder text used, "MM / AA". Our current expiry date transformer does not handle "AA", only "YY"/"YYYY". I wonder what other locale specific placeholders are used for expiration year...

Comment 2

[Tim Giles [:tgiles]]

Attachment: expiration-month-MM-AA-example.html

Minimum example of the placeholder (MM/AA) not being used to determine the expiry date format.

Comment 5

[Tim Giles [:tgiles]]

Attachment: Bug 1687681: Add France specific CC expiry date transformation. r=dimi,sfoster

Our previous regex did not parse "AAAA" or "AA" so I've added this to the transformation regex.
For the year first regex, I added a separate regex because trying to bolt on the missing "AA" caused the resulting parsed result to drop characters for other locales ("yyyy" became "yyy" and the same with "aaaa").

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8077cd932f28
Add France specific CC expiry date transformation. r=dimi,sfoster

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46b6b85d8130
Backed out changeset 8077cd932f28 for causing build bustages. CLOSED TREE

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for causing build bustages

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8077cd932f28d7e30b51c9fe49a0fabe83bd1263&selectedTaskRun=AqURPzQNRI-mGcuIZQXTKg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=348687786&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/46b6b85d8130

Comment 9

[Tim Giles [:tgiles]]

Duplicate tests from the rebase onto central got me, new patch should land this time.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8cfbf461c7c
Add France specific CC expiry date transformation. r=dimi,sfoster

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f8cfbf461c7c

Comment 12

[Alin Ilea]

Verified - Fixed in latest Nightly 93.0a1 (20210820095755) using windows 10 and ebay.fr. The expiry date format is correctly displayed.