1687703 - Add telemetry and a pref to tell if someone has used Ctrl-Tab, so that we can flip the default value of the browser.ctrlTab.recentlyUsedOrder pref to false if they haven't.

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement)

Description

[Blake Winton (:bwinton) (:☕️)]

Similar to home, library or sidebar behavior.
(We'd like to get this in early, so that we have the data we need to make the determination…)

Comment 1

[Emma Malysz]

Attachment: Bug 1687703, add browser.engagement.ctrlTab.has-used pref to check if ctrl-tab is used and default browser.ctrlTab.recentlyUsedOrder pref to false

Comment 2

[Emma Malysz]

Attachment: Bug 1687703, add a preference to see if ctrl-tab is used

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/361b30a2a855
add a preference to see if ctrl-tab is used r=mstriemer

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/361b30a2a855

Comment 5

[Emma Malysz]

Attachment: Bug 1687703, add telemetry for browser.engagement.ctrlTab.has-used pref

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a53bc26736d8
add telemetry for browser.engagement.ctrlTab.has-used pref r=jaws

Comment 7

[Emma Malysz]

Comment on attachment 9202413 [details]
Bug 1687703, add telemetry for browser.engagement.ctrlTab.has-used pref

Beta/Release Uplift Approval Request

• User impact if declined: No user impact, but we are currently not collecting telemetry on this pref. We need this telemetry to make an informed decision on future proton work (such as in Bug 1692303)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open firefox

2. Press "ctrl-tab"
3. Go to about:telemetry
4. Notice "browser.ui.interaction.keyboard.ctrl-tab" has incremented

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No strings
• String changes made/needed: n/a

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a53bc26736d8

Comment 9

[Hani Yacoub, Desktop QA]

I'm trying to verify this bug on the latest Firefox Nightly but I couldn't see "browser.ui.interaction.keyboard.ctrl-tab" in about:telemetry.
Are there any extra steps/prefs that should be added?
Thanks.

Comment 10

[Andrei Petcu]

This is awesome. Setting this flag to false on each new install/profile is a pain. Setting this to false by default is a blessing.

Comment 11

[Emma Malysz]

Hey Hani,

Perhaps the nightly build didn't have the changes in it yet? I was able to reproduce on the most recent version. If you navigate to about:telemetry#keyed-scalars-tab, then "ctrl-tab" should be listed now.

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9202413 [details]
Bug 1687703, add telemetry for browser.engagement.ctrlTab.has-used pref

Low risk and I could check that it works in nightly, let's take it on beta before RC, thanks.

Comment 13

[Pascal Chevrel:pascalc]

Changed back the bug status to affected for 86 so as that the uplift request doesn't get missed. Note that generally speaking, it is better to file a follow up bug for the telemetry patch to uplift than land it in an existing bug. Thanks.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0a6d7342833c

Comment 15

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 87.0a1 on Windows 10 x64, macOS 10.15 and on Ubuntu 20.04.

Comment 16

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 86.0 candidates build 1 on Windows 10 x64, macOS 10.15 and on Ubuntu 20.04.