Closed Bug 1687865 Opened 3 years ago Closed 3 years ago

non-native theme buttons render oddly with no content

Categories

(Core :: Widget, defect)

defect

Tracking

()

RESOLVED FIXED
87 Branch
Fission Milestone M7
Tracking Status
firefox87 --- verified

People

(Reporter: heycam, Assigned: emilio)

References

Details

Attachments

(2 files)

Non-native theme buttons with no content end up with a 4px height, which ends up looking weird. Either they need to get a larger minimum height, or (probably preferably) the drawing code should be aware of this and reduce the radius of the rounded corners in such cases.

Tracking for Fission M7 Beta experiment.

Fission Milestone: --- → M7
Depends on: 1689252
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3073ae54a6e
Fix up the radius in PaintBorderRectWithRadius if we're too small. r=spohl
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Flags: qe-verify+

I have reproduced this issue using Firefox 86.0a1 (2021.01.17) on Ubuntu 20.04 x64.
I can confirm this issue is fixed, I verified using Firefox 88.0a1 and 87.0b4 ( with pref widget.disable-native-theme-for-content = true) on Ubuntu 20.04 x64, Win 8.1 x64 and macOS 11.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: