1687915 - Display a warning message when the --selector argument passed to :screenshot does not match any node

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the console on this page
2. Evaluate :screenshot --selector #this-element-does-not-exist

Expected results

A warning message is displayed to tell me there's no matching element the selector

Actual results

Nothing is displayed at all, which can be confusing for the user

---

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1687915 - [devtools] Display a warning message when the --selector argument passed to :screenshot does not match any node. r=ladybenko.

When the selector doesn't return any node, we log a warning on the page.
A test case is added in browser_jsterm_screenshot_command_selector.js to ensure
this works as expected.

Depends on D102597

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56767936e906
[devtools] Display a warning message when the --selector argument passed to :screenshot does not match any node. r=ladybenko.

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/56767936e906