Closed Bug 1687938 Opened 2 years ago Closed 2 years ago

Fix further fallout from bug 1571672 (UTF8=ACCEPT) - Take 2: 1) Filter action 2) Back/Forward navigation

Categories

(MailNews Core :: Networking: IMAP, defect)

defect

Tracking

(thunderbird_esr78 unaffected)

RESOLVED FIXED
86 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: klaus.bartosch, Assigned: rnons)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #1687452 +++

Part 5) "Filter action" of bug 1687452 wasn't fixed.

Part 6) Note that attachments now open in a completely weird way, see bug 1687937.

Regressed by: 1571672

Here the rule definition.

There are a few more moles to hit here:
https://searchfox.org/comm-central/search?q=acstring.*url&path=.idl&case=false&regexp=true
particularly:
mailnews/base/public/nsIMsgFolder.idl
76 readonly attribute ACString folderURL;

These also looks suspicious:
mailnews/base/public/nsIMessenger.idl
33 void addMsgUrlToNavigateHistory(in ACString aURL);
43 void openURL(in ACString aURL);
48 void loadURL(in mozIDOMWindowProxy ptr, in ACString aURL);
50 void launchExternalURL(in ACString aURL);
The first one is likely to cause mal-function when using Back/Forward navigation. Those buttons need to be added to the toolbar via Customise.

Navigation gives:
JavaScript error: chrome://messenger/content/mailWindowOverlay.js, line 1604: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMessenger.msgHdrFromURI]

Summary: Fix further fallout from bug 1571672 (UTF8=ACCEPT) - Take 2: Filter action not working → Fix further fallout from bug 1571672 (UTF8=ACCEPT) - Take 2: 1) Filter action 2) Back/Forward navigation
Attached patch 1687938.patchSplinter Review

Use AUTF8String for all folder URI attributes in

  • nsIMessenger.idl
  • nsIMsgFolder.idl
  • nsIMsgFilter.idl
Assignee: nobody → remotenonsense
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9198573 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9198573 [details] [diff] [review]
1687938.patch

Review of attachment 9198573 [details] [diff] [review]:
-----------------------------------------------------------------

Thx, r=mkmelin
Attachment #9198573 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → 86 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0b86ff37f1d6ce074c5cefd9bd97903fe5a2dd90
Fix msg filtering and navigation for non-ASCII IMAP folder. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Keywords: regression
You need to log in before you can comment on or make changes to this bug.