1687938 - Fix further fallout from bug 1571672 (UTF8=ACCEPT) - Take 2: 1) Filter action 2) Back/Forward navigation

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Klaus B.]

Attachment: 2021-01-21 12_31_25-Alert.png

+++ This bug was initially created as a clone of Bug #1687452 +++

Part 5) "Filter action" of bug 1687452 wasn't fixed.

Part 6) Note that attachments now open in a completely weird way, see bug 1687937.

Comment 1

[Klaus B.]

Attachment: 2021-01-21 12_31_09-testé - [e-mail] - Thunderbird Daily.png

Here the rule definition.

Comment 2

[Klaus B.]

(deleted, irrelevant)

Comment 3

[Klaus B.]

There are a few more moles to hit here:
https://searchfox.org/comm-central/search?q=acstring.*url&path=.idl&case=false&regexp=true
particularly:
mailnews/base/public/nsIMsgFolder.idl
76 readonly attribute ACString folderURL;

These also looks suspicious:
mailnews/base/public/nsIMessenger.idl
33 void addMsgUrlToNavigateHistory(in ACString aURL);
43 void openURL(in ACString aURL);
48 void loadURL(in mozIDOMWindowProxy ptr, in ACString aURL);
50 void launchExternalURL(in ACString aURL);
The first one is likely to cause mal-function when using Back/Forward navigation. Those buttons need to be added to the toolbar via Customise.

Comment 4

[Klaus B.]

Navigation gives:
JavaScript error: chrome://messenger/content/mailWindowOverlay.js, line 1604: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMessenger.msgHdrFromURI]

Comment 5

[Ping Chen (:rnons)]

Attachment: 1687938.patch

Use AUTF8String for all folder URI attributes in

• nsIMessenger.idl
• nsIMsgFolder.idl
• nsIMsgFilter.idl

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9198573 [details] [diff] [review]
1687938.patch

Review of attachment 9198573 [details] [diff] [review]:
-----------------------------------------------------------------

Thx, r=mkmelin

Comment 7

[Klaus B.]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0b86ff37f1d6ce074c5cefd9bd97903fe5a2dd90
Fix msg filtering and navigation for non-ASCII IMAP folder. r=mkmelin