1688049 - Import Password from CSV dialog has wrong focus

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Andrei Petcu]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Firefox/86.0

Steps to reproduce:

I imported a CSV file with an error (after that I also imported a file with an error).
After the dialog is shown, I press enter.

Actual results:

Nothing.

Expected results:

The error dialog should have had focus on the "learn more" link. The no-error dialog should have had the focus on the "done" button. Enter should have acted as a click on the focused element.

Comment 1

[Andrei Petcu]

Attachment: Bug 1688049 - Fix wrong focused elements on Import Password from CSV dialogs

r=jaws

Depends on D102639

Comment 2

[Bodea Daniel [:danibodea]]

Setting component to match the issue area.
I can't confirm this issue since I'm not sure what kind of CSV files I should be importing and how, but I can see that you created this issue and assigned it to yourself.

I assume you're already expecting a review. Hopefully, you'll get one soon.
If you think a testing confirmation is needed, please give a little more details.

Thank you for your contribution!

Comment 3

[Andrei Petcu]

I made a patch already. I think Sam should know more about the testing need.

Comment 4

[Tim Giles [:tgiles]]

Moving this back to about:logins, since this is a specific issue of how we're handling focus in the about:logins component and not in the DOM in general

Comment 5

[Sam Foster [:sfoster] (he/him)]

:danibodea, For testing the success case with the import summary dialog, We support importing CSV files produced by export from the popular password managers and browser (including our own logins export to CSV from e.g. another firefox profile). So, for example you could:

• In about:logins, create a valid login.
• Open the "..." menu and select "Export logins.." and save the resulting file
• In the menu, select "Remove all logins" and confirm
• Using the keyboard, open the menu, select "Import logins" and select the file you saved earlier from the Export step

ER:

• The "Import Complete" dialog should open. Focus should already be on the "Done" button, so that passing "Enter"/"Return" on the keyboard should dismiss the dialog

We can probably write an automated test for this, but it might be useful to confirm manually.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea5a171f7446
Fix wrong focused elements on Import Password from CSV dialogs r=tgiles

Comment 7

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/ea5a171f7446

Comment 8

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 88.0a1 (Build ID: 20210303215027) and Firefox Beta 87.0b5 (Build ID: 20210302185821) on Windows 10 x64, Ubuntu 20.04 and macOS 11.1.

• After importing logins from a CSV file, the “Import Complete” modal has the “Done” button focused and if pressing the “Enter” key the modal is dismissed.
• Also, if the “Import Error” modal is triggered, the “Learn more” link is focused and if pressing the “Enter” key the SUMO page is opened in a new tab.