1688113 - Native themed widgets appear transparently with the non-aqua appearance

Status: NEW

(Core :: Widget: Cocoa, defect, P3)

Description

[Markus Stange [:mstange]]

This was originally filed as bug 1578917: When using the non-aqua appearance on 10.14+, native theme rendering renders transparent buttons.

We ended up "fixing" that bug by forcing the aqua appearance on for all processes. (Parent process: bug 1623684, content process: bug 1578917).

In the future, we would like to use the non-aqua appearance, see bug 1623686. So we'll need to make sure this bug won't come back at that point.

Comment 1

[Stephen A Pohl [:spohl]]

If we brought the non-native theme over the finish line on macOS, would we still need to do this work here? I believe we just need to port the scrollbars over and we should be in pretty good shape.

Comment 2

[Markus Stange [:mstange]]

If we feel that it's ready to ship soon, then we don't need to do any work here.

Comment 3

[Markus Stange [:mstange]]

Oh, except that we still use native widgets in XUL UI in some windows. We don't want to break those, and I don't want to be blocked on them getting converted to the non-native theme.

Comment 4

[Stephen A Pohl [:spohl]]

Adding [mac:nonnativetheme] whiteboard tag, even though non-native theming will not address this completely (see comment 3).

Comment 5

[Markus Stange [:mstange]]

Actually, we don't need to do anything about this.

We want to stop forcing the aqua appearance for the parent process. We can keep forcing aqua for content processes, to make sure this bug doesn't appear as long as it's still possible to use the native theme in content processes.
Once we've removed support for the native theme in content processes entirely, we can close this bug and also stop forcing the aqua appearance for content processes.