1688301 - Separator space between last pinned tab and first non-pinned tab may not be shown with hidden tabs

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[MrOtherGuy]

Attachment: pinned-tabs-no-space-vs-space.png

STR:

1. Pin a tab
2. Have an extension that can hide tabs such as Simple Tab Groups
3. Open at least two other normal tabs and separate them to two groups

Expected result:
The separator space exists between the pinned tab and the first visible normal tab in regardless of which group is selected

Actual result:
The space only exists when one of the groups is selected.

In the screenshot the upper part shows a on orange group and no space between pinned and normal tabs. The lower part shows a separator space between those tabs as intended.

The space is added by basically this CSS: .tabbrowser-tab[pinned] + .tabbrowser-tab:not([pinned]){ margin-inline-start: 12px } But extensions can hide tabs so the tab that matches that selector may be hidden and thus no space is created.

Extensions cannot hide pinned tabs so maybe add the margin to the last pinned tab instead?

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1688301 - Use a special attribute to insert the space between the pinned tabs and unpinned tabs to account for possible hidden tabs.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d86cb442181e
Use a special attribute to insert the space between the pinned tabs and unpinned tabs to account for possible hidden tabs. r=mconley

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d86cb442181e

Comment 5

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 88.0a1 (2021-03-16) on Windows 10 x64, Windows 7 x64, macOS X 10.15 and on Ubuntu 20.04.