1688415 - Remove NPAPI support in SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

Flash was the last supported plugin using NPAPI. Effective January 12th it is dead. We still need plugin support for possible future EME support but some code in preferences and other places can be removed.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1688415-killflash-cc.2537.patch

Kills some of the prefs. I am unsure about some of the notification code right now but can wait.
We don't have EME support so I can't tell if click to ply or the default state is used for the EME stuff. So I kept it.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1688415-killflash-2537.patch [checked in comment 5 Target 2.53.7]

Minimum patch for disabling the Flash plugin in our release branches.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: Hacked flash can be enabled.
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): tricial
String changes made by this patch: --

Comment 3

[Ian Neal]

Comment on attachment 9198837 [details] [diff] [review]
1688415-killflash-2537.patch [checked in comment 5 Target 2.53.7]

[Triage Comment]
Seems to do what it says on the tin
r/a=me

Comment 4

[Ian Neal]

Comment on attachment 9198836 [details] [diff] [review]
1688415-killflash-cc.2537.patch

Only thing I see that has been missed is removing:
https://searchfox.org/comm-esr60/source/suite/mailnews/jar.mn#15

As you say the notification bar changes can be in a follow-up

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/de0e36d8eb415305dd6373ad31fe27436dcad8fb
Kill Flash. r=IanN a=IanN
Target 2.53.7

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: 1688415-killflash-cc-25312.patch [checked in comment 8 Target 2.53.12]

Patch has baked for some time now in the pre build but I added some more removals and set a few defaults for fallback. Not sure if the fallbacks are still valid in todays web world. Should be all html5 anyway but if not this should help.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: useless gunk in the ui
Testing completed (on m-c, etc.): 2.53.12b1 pre
Risk to taking this patch (and alternatives if risky): NPAPI and Flash are already dead.
String changes made by this patch: Various removals.

Comment 7

[Ian Neal]

Comment on attachment 9261443 [details] [diff] [review]
1688415-killflash-cc-25312.patch [checked in comment 8 Target 2.53.12]

[Triage Comment]
LGTM r/a=me

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/da214111fd19
Remove preferences for NPAPI. r=IanN

Comment 9

[Frank-Rainer Grahl (:frg)]

Lets close. We might need follow-ups later for preferences and notification removal but this can wait.

Comment 10

[Frank-Rainer Grahl (:frg)]

Final removal for 2.53.12:
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a50befbbec1031eecdf9e2da0c13a5f951e50c01
Remove preferences for NPAPI. r=IanN a=IanN