1688703 - rework certviewer utility files so they can be reused elsewhere

Status: RESOLVED FIXED

(Firefox :: Security, task)

Description

[Dana Keeler (she/her) [:keeler]]

certDecoder.js and utils.js are es6 modules, which makes them hard to use in some locations elsewhere in the codebase (e.g. in the devtools). Also, for these files to work correctly, three additional resources need to be manually loaded (the asn1js/pkijs/pvutils bundles). This situation can be simplified into one bundle that can be easily reused elsewhere.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Attachment: Bug 1688703 - rework certviewer utility files so they can be reused elsewhere r?johannh

Before this patch, some certviewer utility files were es6 modules, which means
they could only be used by other es6 modules or a top-level web context. There
are some places (such as the devtools) where it would be nice to use these
utilities without this restriction, so this patch reworks and simplifies the
structure of these utility files so they can be reused elsewhere.

Comment 2

[Dana Keeler (she/her) [:keeler]]

Attachment: Bug 1688703 - reuse certviewer utility files in devtools r?johannh

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c3c130fc7df
reuse certviewer utility files in devtools r=johannh,ochameau

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 7c3c130fc7df (Bug 1688703) for bc leaks.
https://hg.mozilla.org/integration/autoland/rev/f305437a586028e637dbe2bd7e2c29bbe45c73fd

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=7c3c130fc7df241a490d665e4785040486ac9a31&selectedTaskRun=XgNYQTyqQVOkq60YDY47gQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=333842419&repo=autoland&lineNumber=3013

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:keeler, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Dana Keeler (she/her) [:keeler]]

The patch seems to be causing or making more frequent intermittent leaks. I'm investigating.

Comment 7

[Dana Keeler (she/her) [:keeler]]

Attachment: Bug 1688703 - avoid leaks in browser_openTabAndSendCertInfo.js r?johannh

openFromPopUp in browser_openTabAndSendCertInfo.js would open a new browser
window and then close it quickly without checking its contents. It seems that
doing this caused frequent intermittent leaks on ASAN builds. This patch works
around the issue by waiting for the window to finish loading and checking that
it has the expected contents. This patch also adds the same contents check to
other tests in this file that were missing it.

Depends on D106340

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1937e854dd80
reuse certviewer utility files in devtools r=johannh,ochameau
https://hg.mozilla.org/integration/autoland/rev/70926038dbf0
avoid leaks in browser_openTabAndSendCertInfo.js r=johannh

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1937e854dd80
https://hg.mozilla.org/mozilla-central/rev/70926038dbf0