1688887 - Add-on search field no longer works - Uncaught TypeError: aOpenParams is undefined

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[John Bieling]

The function switchToTabHavingURI() does not have a default value for the aOpenParams parameter, but Geoff removed this parameter to a call here which causes the search to fail:
https://searchfox.org/comm-central/source/mail/base/content/utilityOverlay.js#349

I propose to add a default parameter value for the aOpenParams parameter, same as for Firefox.

Comment 1

[John Bieling]

Attachment: bug1688887_set_default_value_for_aOpenParams.patch

Set default value for aOpenParams parameter.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9199261 [details] [diff] [review]
bug1688887_set_default_value_for_aOpenParams.patch

Review of attachment 9199261 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f5391028d2fd
Set default value for aOpenParams parameter in switchToTabHavingURI(). r=mkmelin DONTBUILD

Comment 4

[Wayne Mery (:wsmwk)]

Thanks for fixing this. Danny Colin indicates this is now working on nightly. So ready for uplift to beta?

Beta shows
Uncaught TypeError: aOpenParams is undefined
switchToTabHavingURI chrome://messenger/content/mailWindow.js:987
openLinkIn chrome://communicator/content/utilityOverlay.js:349
searchAddons chrome://mozapps/content/extensions/aboutaddons.js:1239
handleEvent chrome://mozapps/content/extensions/aboutaddons.js:1203
_fireCommand chrome://global/content/elements/search-textbox.js:231
_enterSearch chrome://global/content/elements/search-textbox.js:249
on_keypress chrome://global/content/elements/search-textbox.js:212
handleEvent chrome://global/content/customElements.js:466
mailWindow.js:987:5

Comment 5

[John Bieling]

Comment on attachment 9199261 [details] [diff] [review]
bug1688887_set_default_value_for_aOpenParams.patch

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9199261 [details] [diff] [review]
bug1688887_set_default_value_for_aOpenParams.patch

[Triage Comment]
Approved for beta. looks like low risk ;)

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/eb387f4e49b8

Comment 8

[WaltS48 [:walts48]]

Add-ons search working for me in my tests of 86.0b2 on Windows 10 and Fedora 33 Workstation.