1688978 - Possibly make the input[type="number"] arrows accomodate the available vertical space, when zoomed in, with non-native theming

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Itiel]

Attachment: 220% zoom in

In 100% (default) zoom, the arrows accomodate the available vertical space, but when zoomed in there's a blank space below and above the arrows. See attached.

Comment 1

[Itiel]

Attachment: Default zoom

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1688978 - Make non-native theme widgets grow with zoom as usual, except for scrollbars. r=mstange,spohl

This matches other browsers, and also common sense (I'd be ok letting
scrollbars grow or shrink too tbf, but...).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c8750c7f296
Make non-native theme widgets grow with zoom as usual, except for scrollbars. r=mstange

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1688978 - Snap border widths in the non-native theme like we snap layout borders. r=mstange

We might want to snap focus outline widths as well, but that's harder
because it has various segments and separation between them, so we
probably want to snap those separately... So for now only border rects
probably makes sense.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccacb0fa77d9
Add a missing argument in mac-only code. CLOSED TREE

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17df09fc7b4c
Snap border widths in the non-native theme like we snap layout borders. r=mstange

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5c8750c7f296
https://hg.mozilla.org/mozilla-central/rev/ccacb0fa77d9
https://hg.mozilla.org/mozilla-central/rev/17df09fc7b4c