1689045 - Broken UI in Message Header after bug 1686603

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screen Shot 2021-01-26 at 10.12.02 PM.png

It seems that the Message Header is broken on trunk in macOS.
I didn't notice this issue on Linux, and I'm not sure if it's happening on Windows.

The addressing area doesn't grow as it's supposed to. Adding a flex: 1; CSS attribute to that container fixes it, but I'm not sure is the right fix and I'd be curious to know what broke it.

Comment 1

[Richard Marti (:Paenglab)]

Must be something in the latest check-ins from m-c. I checked before, all ok and with latest I see this too.

Comment 2

[Thomas D. (:thomas8)]

Good catch, Alex!

Comment 3

[Richard Marti (:Paenglab)]

This is a regression from bug 1686603.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1689045-expandedHeaders2-flex.patch

Fixing it by adding the flex: 1;. I also removed the unneeded html|table selector part.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9199525 [details] [diff] [review]
1689045-expandedHeaders2-flex.patch

Review of attachment 9199525 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!

::: mail/themes/shared/mail/messageHeader.css
@@ +285,5 @@
> +#expandedHeaders2 {
> +  flex: 1;
> +}
> +
> +#expandedHeaders,

Are you sure the #expandedHeaders doesn't need the flex as well?

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani (:aleca) from comment #5)

Are you sure the #expandedHeaders doesn't need the flex as well?

This doesn't work because his parent has no display: flex;. And probably not needed because the parent has display: block;.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f6354f32e562
Add a flex to expandedHeaders2 to expand it over the whole width. r=aleca

Comment 8

[Daniel Holbert [:dholbert]]

I don't think bug 1686603 was meant to have observable changes, really. TYLin, would you mind taking a look here and seeing if this fallout makes sense or was unexpected (& possibly indicative of there being a risk for potential breakage on the web, too)?

Comment 9

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Filed bug 1689719 to investigate the rendering difference of <table> as a flex item.