1689095 - [Dark Theme] The Search separator line is too bright on NNT when the page is scrolled down

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: search separator line too bright on dark theme.gif

[Affected versions]:

• Firefox Nightly 87.0a1, BuildID 20210127093943

[Affected Platforms]:

• Windows 10
• macOS 10.15
• Linux MX 4.19

[Prerequisites]:

• Have a new Firefox profile.
• Have the browser.newtabpage.activity-stream.newNewtabExperience.enabled pref set to true.
• Have the browser theme set to Dark.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a new tab and scroll down the page until the Search bar is stuck to the top of the page.
3. Observe the Search separator line.

[Expected results]:

• The line is set at 10% opacity.

[Actual results]:

• The line is set at 100% opacity.

[Additional notes]:

• The issue is not reproducible on the old New Tab experience. And as far as I can tell it's due to the fact that we're using a different way to define the color on the old New Tab experience - RGBA 249 249 250 0.1 vs HEX #E1E0E6.
• The issue is not reproducible/not noticeable on Light/Default themes (OS light).
• Attached a screen recording of the issue.

@ewright, could you please take a look at this?

Comment 1

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Fixing my own mid air collision, sorry for the spam.

Comment 2

[Erica Wright [:ewright]]

Attachment: Bug 1689095 - Add dark theme color to the scroll section bottom border.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f92249410a61
Add dark theme color to the scroll section bottom border. r=prathiksha

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f92249410a61

Comment 5

[Erica Wright [:ewright]]

Comment on attachment 9199612 [details]
Bug 1689095 - Add dark theme color to the scroll section bottom border.

Beta/Release Uplift Approval Request

• User impact if declined: Users enrolled in the new tab experience experiments will see a bright bar under their search bar if they are using dark theme and scroll down. This bar should be dimmer. This is a regression from Bug 1688272 which was also uplifted,
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS only change, behind a pref.
• String changes made/needed: none

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9199612 [details]
Bug 1689095 - Add dark theme color to the scroll section bottom border.

Approved for 86 beta 4, thanks.

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0e6ac9f3e796

Comment 8

[Marius Coman [:mcoman], Ecosystem QA, PTO until 20th of October, for any testing requests ping :poiegas]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (86.0b4 Build ID - 20210131185630) and the latest Firefox Nightly (87.0a1 Build ID - 20210131211743) installed on Windows 10 x64, Windows 7 x64, and Windows 8.1 x32. Now, I can confirm that the separator line's color on "Dark" theme is #53515F.