1689208 - RaceCacheWithNetwork is racing on 5G cellular networks

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect, P2)

Description

[Andrew Creskey [:acreskey]]

There is logic in place so that we don't RaceCacheWithNetwork when the user is on a cellular network (to avoid excess data usage).
See Bug 1377570.

However on 5G cellular networks, the network type is not being correctly identified, and is reported as nsINetworkLinkService::LINK_TYPE_UNKNOWN.

I can see this in logs via an instrumented build that I made:

nsHttpChannel::MaybeRaceCacheWithNetwork: netLinkType 0

See the link type enumeration here.

Further logs have shown that we are in fact racing cache with network when on 5G cellular.

Comment 1

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Thanks for the report. This is a good point.
I think we should:

1. Make geckoview code report a 5G network when necessary
2. Not race for UNKNOWN network types on Android (doesn't seem like a huge loss)

Comment 2

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1689208 - Add LINK_TYPE_5G to nsINetworkLinkService and report it on Android r=#necko

Comment 3

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1689208 - Don't race for LINK_TYPE_UNKNOWN on Android r=#necko

Depends on D103305

Comment 4

[Andrew Creskey [:acreskey]]

(In reply to Valentin Gosu [:valentin] (he/him) from comment #1)

Thanks for the report. This is a good point.
I think we should:

1. Make geckoview code report a 5G network when necessary
2. Not race for UNKNOWN network types on Android (doesn't seem like a huge loss)

I think not racing for UNKNOWN on Android is a great future-proof solution.
(And of course Android devices don't have slow platter drives, so in the unlikely event of a wifi or wired connection being identified as UNKNOWN, the loss is small).
And great to see a same day patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edeb8bba12e8
Add LINK_TYPE_5G to nsINetworkLinkService and report it on Android r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/924b2e399c4b
Don't race for LINK_TYPE_UNKNOWN on Android r=necko-reviewers,kershaw

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/edeb8bba12e8
https://hg.mozilla.org/mozilla-central/rev/924b2e399c4b