1689230 - Simplify gViewController API methods

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Tim Nguyen :ntim]

After bug 1525179:

• gViewController.loadInitialView is the same as gViewController.replaceView for current usages, since currentViewId is always an empty string or null

• gViewController.replaceView isn't used aside for replaceWithDefaultViewFn. It could be implemented as an argument for gViewController.loadView

• gViewController.updateState is the same as gViewController.loadViewInternal, with slightly different args, these can be combined in a renderView method.

• initialViewSelected is essentially the same as checking for the existence of currentViewId

• I think it's worth adding a resetView helper which would be the equivalent of replaceWithDefaultViewFn

This way, gViewController can have a clear API with 3 methods: loadView/resetView/renderView which matches how gViewController is actually used. Also, external callers can call into loadView without knowing the initialization state.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1689230 - Simplify gViewController API methods. r=rpl

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/033aea12b973
Simplify gViewController API methods. r=rpl

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/033aea12b973