1525179 - [about:addons] Use an HTML document at the root of about:addons

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Mark Striemer [:mstriemer]]

Once all the views, the sidebar, and the heading have been converted to HTML, the entire document can be switched to an HTML document.

Comment 1

[Deleted Account]

It can be fixed now.

Comment 3

[Deleted Account]

Now since bug 1614653 has been fixed, this should be easier to accomplish.

Comment 4

[Deleted Account]

Can you re-consider this?

Comment 5

[Tim Nguyen :ntim]

Attachment: html-aboutaddons-prototype.diff

Just a small test on top of bug 1674890. When opening chrome://mozapps/content/extensions/aboutaddons.html top-level, all content loads. Interacting with the page doesn't work though, haven't figured out why.

Obviously this is just a prototype.

Comment 6

[Tim Nguyen :ntim]

Attachment: Bug 1525179 - Use aboutaddons.html at the root of about:addons.

Comment 7

[Deleted Account]

What is the status of this bug now?

Comment 8

[Deleted Account]

(In reply to Nicohumor from comment #7)

What is the status of this bug now?

A patch has already been made.

Comment 9

[Deleted Account]

(In reply to Nicohumor from comment #8)

(In reply to Nicohumor from comment #7)

What is the status of this bug now?

A patch has already been made...

So can't it just be fixed now?

Comment 10

[Tim Nguyen :ntim]

(In reply to Nicohumor from comment #9)

What is the status of this bug now?

Luca is actively working on it. This patch is pretty close to finished. I expect this should be done after a round or two of reviews, which shouldn't be too long (Firefox 87 or at worst 88).

Comment 11

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1525179 - Removed fluent ids unused after removed extensions.xhtml.

Depends on D96472

Comment 12

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1525179 - Removed checkOpenWindows helper checking unused Addons:Manager/Compatibility/Install window types. r?robwu

Depends on D103198

Comment 13

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1525179 - Removed duplicate getAddonCard helper functions used in AOM tests. r?robwu

Depends on D103199

Comment 14

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1525179 - Ensure InlineOptionsBrowser does not leave a loadURI call pending if disconnected while rendering. r?robwu

Depends on D103200

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/294868c1cf03
Use aboutaddons.html at the root of about:addons. r=robwu
https://hg.mozilla.org/integration/autoland/rev/16c72ec43017
Removed fluent ids unused after removed extensions.xhtml. r=fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/1977aa9c5dbd
Removed checkOpenWindows helper checking unused Addons:Manager/Compatibility/Install window types. r=robwu
https://hg.mozilla.org/integration/autoland/rev/0407e9498a4f
Removed duplicate getAddonCard helper functions used in AOM tests. r=robwu
https://hg.mozilla.org/integration/autoland/rev/fb98df8989f9
Ensure InlineOptionsBrowser does not leave a loadURI call pending if disconnected while rendering. r=robwu

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/294868c1cf03
https://hg.mozilla.org/mozilla-central/rev/16c72ec43017
https://hg.mozilla.org/mozilla-central/rev/1977aa9c5dbd
https://hg.mozilla.org/mozilla-central/rev/0407e9498a4f
https://hg.mozilla.org/mozilla-central/rev/fb98df8989f9

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/55b35aef940e
Port bug 1525179 - Use aboutaddons.html at the root of about:addons. rs=bustage-fix