Closed
Bug 1689234
Opened 5 years ago
Closed 5 years ago
Remove hideView method from aboutaddons.js
Categories
(Toolkit :: Add-ons Manager, task, P2)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(1 file)
After bug 1525179, hideView will only be called in showViewInternal, which calls showView afterwards. showView already saves scroll offsets and clears the container like hideView does. This is a redundant step.
(It may be the case that showView is actually saving the wrong scroll offset, since hideView clears the container before that).
Let's fix both issues.
|
Assignee | |
Comment 1•5 years ago
|
||
This is only called right before showView is called, which already does what hideView does (save scroll offsets and clear content).
|
||
Updated•5 years ago
|
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
|
||
Updated•5 years ago
|
Severity: -- → N/A
Priority: -- → P2
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/43d82652aba7
Remove hideView function from aboutaddons.js. r=rpl
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox87:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•