Closed Bug 1689234 Opened 4 months ago Closed 4 months ago

Remove hideView method from aboutaddons.js

Categories

(Toolkit :: Add-ons Manager, task, P2)

Product:
Toolkit
Component:
Add-ons Manager
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file)

Bug 1689234 - Remove hideView function from aboutaddons.js. r=rpl
48 bytes, text/x-phabricator-request
Details | Review

After bug 1525179, hideView will only be called in showViewInternal, which calls showView afterwards. showView already saves scroll offsets and clears the container like hideView does. This is a redundant step.

(It may be the case that showView is actually saving the wrong scroll offset, since hideView clears the container before that).

Let's fix both issues.

This is only called right before showView is called, which already does what hideView does (save scroll offsets and clear content).

Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P2
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/43d82652aba7
Remove hideView function from aboutaddons.js. r=rpl

https://hg.mozilla.org/mozilla-central/rev/43d82652aba7

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.