1689240 - Clean-up load/shutdown/render functions in view-controller.js and aboutaddons.js

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[Tim Nguyen :ntim]

I think this is worth doing after bug 1525179 and all the related clean ups.

In short:

• showView/loadViewInternal are combined into one gViewController method
• gViewController.initialize/initializeView are combined into an aboutaddons.js method
• shutdown in view-controller.js is moved into the unload listener added in the initialize method

To make sure gViewController remains an independent component, the view-specific logic from both showView and loadViewInternal can be extracted out into a defineView/registerView method that's called from aboutaddons.js. The newly combined function would loop through the registered views and call the right view load function. This also allows getting rid of the hardcoded viewTypes in loadViewInternal.

gViewController.registerView("discover", (container) => {
  let discoverView = new DiscoveryView();
  let elem = discoverView.render();
  await document.l10n.translateFragment(elem);
  container.append(elem);
});

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1689240 - Inline loadViewFn/replaceWithDefaultViewFn functions. r=rpl

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1689240 - Clean-up load/shutdown/render functions in view-controller.js and aboutaddons.js.

Depends on D103262

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1689240 - Move ScrollOffsets from aboutaddons.js to view-controller.js.

Depends on D103263

Comment 4

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/jobs?repo=try&revision=d8d1ea461061849377aeba84f6a2115231782d0b

Comment 5

[Tim Nguyen :ntim]

Attachment: Bug 1689240 - Make gViewController a custom element.

Comment 6

[Phabricator Automation]

Comment on attachment 9201655 [details]
Bug 1689240 - Make gViewController a custom element.

Revision D104325 was moved to bug 1691271. Setting attachment 9201655 [details] to obsolete.

Comment 7

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=078059c9bef51ab3663229f3e5a4dc2e85cdf574

Comment 8

[Tim Nguyen :ntim]

ni? rpl about taking over in case he has time :)

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1689240 - Move CategoriesBox event handling into handleEvent method and remove listener on disconnection. r?robwu!

Depends on D104190

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1689240 - Move observer server notifications related to the EM-* topic in view-controller.js. r?robwu!

Depends on D108510

Comment 11

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1689240 - Throw an explicit error if aboutaddons loadView is called too early. r?robwu!

Depends on D108511

Comment 12

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1689240 - Throw an explicit error if aboutaddons views are being defined more than once. r?robwu!

Depends on D108512

Comment 13

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1689240 - Rename aboutaddons custom event from ViewChanged to view-loaded. r?robwu!

Depends on D108513

Comment 14

[Luca Greco [:rpl] [:luca] [:lgreco]]

I'm taking over this bug as agreed with ntim.

Comment 15

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1689240 - Fix intermittent timeout in browser_webext_incognito. r?robwu!

This test-only change does fix a TV job failure that I did notice in some of my last push to try
(the one that I did notice was happening on the TV job while running in linux x65 opt build).

Depends on D108514

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a9c8bc14824
Inline loadViewFn/replaceWithDefaultViewFn functions. r=rpl
https://hg.mozilla.org/integration/autoland/rev/3fbfc79bf96a
Clean-up load/shutdown/render functions in view-controller.js and aboutaddons.js. r=rpl
https://hg.mozilla.org/integration/autoland/rev/292d29ba4e9d
Move ScrollOffsets from aboutaddons.js to view-controller.js. r=rpl
https://hg.mozilla.org/integration/autoland/rev/5f5a855bce31
Move CategoriesBox event handling into handleEvent method and remove listener on disconnection. r=robwu
https://hg.mozilla.org/integration/autoland/rev/b08cd0d38cb5
Move observer server notifications related to the EM-* topic in view-controller.js. r=robwu
https://hg.mozilla.org/integration/autoland/rev/0ce37bd2f2cd
Throw an explicit error if aboutaddons loadView is called too early. r=robwu
https://hg.mozilla.org/integration/autoland/rev/cecb522cad4f
Throw an explicit error if aboutaddons views are being defined more than once. r=robwu
https://hg.mozilla.org/integration/autoland/rev/40cdb964eb03
Rename aboutaddons custom event from ViewChanged to view-loaded. r=robwu
https://hg.mozilla.org/integration/autoland/rev/b900e6890599
Fix intermittent timeout in browser_webext_incognito. r=robwu

Comment 18

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3a9c8bc14824
https://hg.mozilla.org/mozilla-central/rev/3fbfc79bf96a
https://hg.mozilla.org/mozilla-central/rev/292d29ba4e9d
https://hg.mozilla.org/mozilla-central/rev/5f5a855bce31
https://hg.mozilla.org/mozilla-central/rev/b08cd0d38cb5
https://hg.mozilla.org/mozilla-central/rev/0ce37bd2f2cd
https://hg.mozilla.org/mozilla-central/rev/cecb522cad4f
https://hg.mozilla.org/mozilla-central/rev/40cdb964eb03
https://hg.mozilla.org/mozilla-central/rev/b900e6890599

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5ca6c579781e
Port bug 1689240 - Rename aboutaddons custom event from ViewChanged to view-loaded. rs=bustage-fix

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/74e28bcd68ac
Port bug 1689240 (take 2) - Rename aboutaddons custom event from ViewChanged to view-loaded. rs=bustage-fix

Comment 21

[Tim Nguyen :ntim]

Attachment: Bug 1689240 - Remove unused exported ESLint comment from aboutaddons.js. DONTBUILD

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3758b0aed2b9
Remove unused exported ESLint comment from aboutaddons.js. DONTBUILD

Comment 23

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3758b0aed2b9