1689250 - Remove gViewController.isLoading property

Status: NEW

(Toolkit :: Add-ons Manager, task, P3)

Description

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/search?q=gViewController.isLoading&path=&case=false&regexp=false

There are 8 test usages. 4 of them just assert that the view loaded, those can just be removed. 4 of them use it to wait for the view to load:

• they should always try to use the ViewChanged event when possible or use the wait_for_view_load helper
• wait_for_view_load shouldn't rely on isLoading. If some tests rely on that:
  • either the test shouldn't wait for view load at all.
  • either there's a race condition that should be fixed either in the test or in the AM code

Either way, another way to check if a view is loading is to check for empty textContent.