1689290 - The "single-site" link handler should be able to handler IP addresses

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

The same-site link handler uses the eTLD service to determine if two URL are from the same site, but this doesn't handle IP addresses. If it's the same IP, it should be considered the same site.

Comment 1

[Geoff Lankow (:darktrojan)]

I mean single-site. I really should know what I called things.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1689290 - Fix handling of IP addresses in the "single-site" link handler. r?mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

That should do the trick. I've started a Try run to see if I've managed to break anything else: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=f48b940da74dbcff05d85edee2bf13571fc36172

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf3be1f71ed5
Fix handling of IP addresses in the "single-site" link handler. r=mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9199734 [details]
Bug 1689290 - Fix handling of IP addresses in the "single-site" link handler. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: not a major problem but this does affect a project Magnus is working on
Testing completed (on c-c, etc.): on c-c 5 days
Risk to taking this patch (and alternatives if risky): none

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9199734 [details]
Bug 1689290 - Fix handling of IP addresses in the "single-site" link handler. r?mkmelin

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/69b00405918c