1689372 - Simplify History subview

Status: VERIFIED FIXED

(Firefox :: Menus, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

This is something that can ship pre-Proton, so it can happen directly on PanelUI-history here: https://searchfox.org/mozilla-central/rev/0dfbe5a699cc6c73cf8c14d1aa10ba10ef3ec8fa/browser/base/content/browser.xhtml#980-1022

The new History subview structure should be:

History  <header>
<separator>
Clear Recent History...
<separator>
Recent History <subheader>
<list of recent history>
<separator>
Recently Closed Tabs >
Recently Closed Windows >
<separator>
Manage History

What we need to do:

1. Remove the "View History Sidebar" item
2. Put the "Recently Closed Tabs" and "Recently Closed Windows" items below the "Recent History" list.
3. Convert the "Show All History" into a normal toolbarbutton subview item, and place it below the "Recently Closed Windows" entry, after a separator
4. Ensure that the "Recently Closed Tabs" submenu entry is disabled if there are not recently closed tabs. Similarly, the "Recently Closed Windows" submenu entry should be disabled if there are no recently closed windows.

One thing we need to figure out with UX is whether or not we're going to change the limit on how many Recent History to show - that list can get quite long. Do we limit the number to show, or do we make the list a fixed maximum height with a scrollbar? Or something else entirely?

Remember when updating strings to ensure that they're not re-used elsewhere - if so, double-check that the propagated change is acceptable with UX, or create a new string just for the menu.

Also remember that if you're updating a string, you still have to update the ID of it so that our localizers know to re-translate.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

(Naturally, any tests that rely on the old structure or old behaviours will need to be modified as well)

Comment 2

[Emma Malysz]

Attachment: Bug 1689372, simplify history panel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6d2e03d3069
simplify history panel r=mconley,fluent-reviewers,flod

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_history_recently_closed.js

backout: https://hg.mozilla.org/integration/autoland/rev/a7d2305ae8aa4989f66f9934552555e95f6241d8

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=a6d2e03d3069e2bcbda6aa44ad090c3367b2f3d0&group_state=expanded&selectedTaskRun=aGyIh4dXRW6XPwqURY26pw.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=328872501&repo=autoland&lineNumber=3451

[task 2021-02-04T18:55:08.603Z] 18:55:08 INFO - TEST-PASS | browser/components/customizableui/test/browser_history_recently_closed.js | History button appears in Panel Menu - {"_inheritedElements":{".toolbarbutton-icon":{},".toolbarbutton-menu-dropmarker":null},"initializedAttributeInheritance":true} == true -
[task 2021-02-04T18:55:08.603Z] 18:55:08 INFO - Console message: [JavaScript Warning: "browser.ui.interaction.pinned_overflow-menu - Unknown scalar."]
[task 2021-02-04T18:55:08.604Z] 18:55:08 INFO - Buffered messages finished
[task 2021-02-04T18:55:08.606Z] 18:55:08 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_history_recently_closed.js | Recently closed tabs button disabled - "" == true - JS frame :: chrome://mochitests/content/browser/browser/components/customizableui/test/browser_history_recently_closed.js :: testRecentlyClosedDisabled :: line 59
[task 2021-02-04T18:55:08.606Z] 18:55:08 INFO - Stack trace:
[task 2021-02-04T18:55:08.606Z] 18:55:08 INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_history_recently_closed.js:testRecentlyClosedDisabled:59
[task 2021-02-04T18:55:08.607Z] 18:55:08 INFO - TEST-PASS | browser/components/customizableui/test/browser_history_recently_closed.js | Recently closed windows button disabled - "true" == true -

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14a7af25b9f4
simplify history panel r=mconley,fluent-reviewers,flod

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out changeset 14a7af25b9f4 (Bug 1689372) for causing failures in browser_history_recently_closed.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=14a7af25b9f4220fddcf499817f02738a1e82bf9&selectedTaskRun=bDSIvygDTYKa5wK5ARfaeg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=328933561&repo=autoland&lineNumber=12193

Backout: https://hg.mozilla.org/integration/autoland/rev/e205534ad7bf5dc3139b9719f36aa442150db0c0

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfbbd3864b2f
simplify history panel r=mconley,fluent-reviewers,flod

Comment 8

[Alexandru Michis [:malexandru]]

Backed out changeset dfbbd3864b2f (Bug 1689372) for causing bc failures in browser_history_recently_closed.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/c82d6bc126b5c7a6a1c8b584fc69b7b293c4b2fe

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&tochange=c82d6bc126b5c7a6a1c8b584fc69b7b293c4b2fe&fromchange=e44f1beebeba29590af1df1538f5363f5d9e7317&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt%2Cmochitests%2Ctest-linux1804-64-tsan%2Fopt-mochitest-browser-chrome-e10s%2Cbc18&selectedTaskRun=E6NRFOiyR_6L03G6GtyH9g.0&group_state=expanded

Failure log: https://treeherder.mozilla.org/logviewer?job_id=329042382&repo=autoland&lineNumber=3306

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/400050be36f0
simplify history panel r=mconley,fluent-reviewers,flod

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/400050be36f0

Comment 11

[Raluca Popovici, Desktop QA]

Verified - Fixed in latest Fx 87.0, Fx 88.0.1, Fx 89.0b10 and Nightly 90.0a1 using Windows 10, Ubuntu 20.04 and MacOS 11.