1689405 - Do initial simplification of the Library menu

Status: RESOLVED FIXED

(Firefox :: Menus, task)

Description

[Mike Conley (:mconley) (:⚙️)]

This is something that can ship pre-Proton, so it can happen immediately, and doesn't need to be behind a pref.

This is mainly removal, so should be reasonably straight-forward (he said, tempting fate).

For now, Library should be as follows:

Bookmarks >
View Pocket List
History >
Downloads

What we need to do:

1. Remove the "Synced Tabs" and "Recent Highlights" sections.
2. Have the "Downloads" button open up the Downloads section in the Library window. That can be done by using the DownloadsPanel.showDownloadsHistory(); function, like this. This also means removing the "subviewbutton-nav" class from the item to get rid of the ">".
3. With the Downloads subview no longer accessible, we can fully remove it. That means getting rid of DownloadsSubview.jsm, this chunk of markup, and any tests that exercise the Downloads subview. Also a good opportunity to cull any strings that aren't being used anymore with that subview gone.

Naturally, any tests that rely on the old structure or old behaviours will need to be modified as well.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Late breaking additional change - we're okay to remove View Pocket List as well. This means removing this entry, the pocketMenuitem.label DTD, and any styles or tests involving appMenu-library-pocket-button: https://searchfox.org/mozilla-central/search?q=appMenu-library-pocket-button&path=&case=false&regexp=false

Comment 2

[Emma Malysz]

Attachment: Bug 1689405: remove components of library panel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/164e8109e012
remove components of library panel r=mconley

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/164e8109e012

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Release Note Request (optional, but appreciated)
[Why is this notable]:

We're changing the composition of one of our default toolbar item menus.

[Affects Firefox for Android]:

No.

[Suggested wording]:

We've removed some items from the Library button that weren't used often, or have other access points in the browser.

[Links (documentation, blog post, etc)]:

None.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Setting docs-needed since we're removing the following items from the Library menu:

• Synced Tabs (these can be accessed via the Firefox Accounts submenu
• Recent highlights
• View Pocket List (users can go to https://getpocket.com/my-list to view their list)

Comment 7

[Julien Cristau [:jcristau]]

Added to the 87.0beta release notes

Comment 8

[Alice Wyman]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #6)

Setting docs-needed since we're removing the following items from the Library menu:
<snip>

• View Pocket List (users can go to https://getpocket.com/my-list to view their list)

I updated https://support.mozilla.org/en-US/kb/save-web-pages-later-pocket-firefox for fx87

Comment 9

[ycarya]

Hi,
Why did you remove the "view pocket list" from the library menu? This is a regression...!
We have a button to save the pages but none to go in his list!
Why was it on this menu? If you really wanted to remove it, you should have first added a feature in the "pocket" button to access its list.
Now, we have to lose 5 minutes to find the link to your pocket list even if you can add a bookmark afterward.

In short, it was better before. Please put back this "view pocket list" button in the library menu in the next version of FF ;-)

Comment 10

[Thommie Rother]

Aside from the (reasonable) intention to simplify things, from a usability perspective, it makes no sense to still have an option to add an URL to getpocket (>> right click), but remove the convenient link to the corresponding list on the pocket service.

Please refer to https://support.mozilla.org/en-US/questions/1330746 for some "unhappy" user feedback on this decision ...

Thanks, Thommie