1694446 - Remove pocket library animation now that "view pocket list" is no longer a library item

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P1)

Description

[:Gijs (he/him)]

We removed "View Pocket List" from the library, so the animation no longer makes sense.

Comment 1

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
This change (by bug 1689405) made 87 so we should remove the animation in that release.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1694446 - remove pocket library animation, r?emalysz

I'm keeping the generic 'animate' selectors which are still used for the bookmark/star animation.
This should make it easier to add other animations to the library in future, if that
ends up useful, and making them more specific to the star animation doesn't seem like it gains
us anything. The de-duplication from bug 1393565 helps a lot here.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ee9ae864a80
remove pocket library animation, r=emalysz,desktop-theme-reviewers,harry

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6ee9ae864a80

Comment 5

[:Gijs (he/him)]

Comment on attachment 9204891 [details]
Bug 1694446 - remove pocket library animation, r?emalysz

Beta/Release Uplift Approval Request

• User impact if declined: Confusing animation when saving items to pocket
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We're only removing some images / CSS files, and a single JS invocation for a shared helper function.
• String changes made/needed: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9204891 [details]
Bug 1694446 - remove pocket library animation, r?emalysz

Approved for 87.0b3.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5e39a0c1f2a8