1689509 - Thread staircase lines nearly invisible when Dark Mode is OFF

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[David Foster]

Attachment: Thunderbird - Threads - Staircase Lines Nearly Invisible - 1 & 2.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.96 Safari/537.36

Steps to reproduce:

• Ensure your OS is configured such that Dark Mode is OFF. (I'm on macOS 10.14.6 Mojave.)
• Upgrade Thunderbird from 60.9.1 -> 68.12.1 -> 78.7.0.
• Open any mailbox in Thunderbird that has threaded messages.
• Find a threaded message and click the caret icon to expand it.

Actual results:

• There is an off-white staircase line the looks like └ which appears. But because the background is pure-white, it's nearly impossible to see. See screenshot.

Problem exists in at least Thunderbird 78.7.0 and 68.12.1. Problem does NOT exist in Thunderbird 60.9.1.

Expected results:

• There is an dark gray staircase line the looks like └ which appears clearly against the white background.
• The staircase line continues to be easy to see when its row is selected.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1689509-mac-tree-line-color.patch

The toolkit default of ThreeDShadow is on Mac not optimal as it is a light gray. Because tree-lines aren't used in FX it's very unlikely they will fix this. I'm using the normal text colour now on Mac. I had also set the (selected, focus) colour because our normal rule oversteered the toolkit one.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9200098 [details] [diff] [review]
1689509-mac-tree-line-color.patch

Review of attachment 9200098 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks.
Just a tiny nit: there's an extra `-` symbol at the end of the commit message.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1689509-mac-tree-line-color.patch

Fixed the comment.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ebad15c4d08
Use a better visible tree-line color for default Mac theme. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9200175 [details] [diff] [review]
1689509-mac-tree-line-color.patch

[Approval Request Comment]
User impact if declined: amost invisible tree-line on Mac with default theme.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1689509-mac-tree-line-color-ESR.patch

[Approval Request Comment]
User impact if declined: amost invisible tree-line on Mac with default theme.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[David Foster]

Thanks for fixing this bug folks!

What version of Thunderbird should I expect to see this fixed in? 87 (since this bug is marked as "87 Branch" milestone)?

FWIW, I'm a bit confused about how Thunderbird versioning works in general. Version numbers seem to go up by 7-10 each major release rather than by 1 according to Wikipedia's page. The developer site talks about the roadmap for TB 91 which presumably isn't the next release since it's more than 10 units greater than the current version 78. Is there a doc page somewhere that explains how the Thunderbird project chooses its version numbers?

Comment 8

[Richard Marti (:Paenglab)]

87 is the actual development build. I asked to land it too on Beta (86) and ESR, which is the actual public version. Maybe it can land in a next 78.7.x version or at least in 78.8.

Comment 9

[David Foster]

Maybe it can land in a next 78.7.x version or at least in 78.8.

This would certainly be appreciated. I like being able to read threaded email, and I'm not adventurous enough to put myself on the Beta channel :)

Is there a doc page somewhere that explains how the Thunderbird project chooses its version numbers?

Any comment here? Based on what you've said it sounds like there's a Stable/ESR channel, a Beta channel, and (presumably) a Nightly channel, all of which receive patches, and may have certain versioning conventions that I haven't figured out yet. Does this sound correct?

Comment 10

[Richard Marti (:Paenglab)]

(In reply to David Foster from comment #9)

Any comment here? Based on what you've said it sounds like there's a Stable/ESR channel, a Beta channel, and (presumably) a Nightly channel, all of which receive patches, and may have certain versioning conventions that I haven't figured out yet. Does this sound correct?

Correct. TB stable are based on the ESR builds (support for around 1 year). All versions in-between are only for development (Nightly and beta).

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9200209 [details] [diff] [review]
1689509-mac-tree-line-color-ESR.patch

[Triage Comment]
Approved for esr78 (making exception for taking this direct to esr without beta)

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 78.7.1:
https://hg.mozilla.org/releases/comm-esr78/rev/7477acada2ca

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9200175 [details] [diff] [review]
1689509-mac-tree-line-color.patch

[Triage Comment]
Approved for beta

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/cd644ccb5cd2