1689553 - Compact mode folder view fails in Thunderbird 86

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect, P1)

Description

[juraj.masiar]

Attachment: Screenshot 2021-01-29 08.49.32.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0

Steps to reproduce:

My Thunderbird beta 85 updated to 86 and failed to start correctly.
Restarting in Safe mode helped but disabling addons didn't helped.
After I saw the error logs I've noticed error in the "toggleCompactMode" so I've changed folder view and then it works again.

Comment 1

[juraj.masiar]

Attachment: error logs

This is the error log, I don't have a text version anymore...

Comment 2

[Magnus Melin [:mkmelin]]

Must be from bug 1163555.

Comment 3

[Alessandro Castellani [:aleca]]

Thanks for the report.

After I saw the error logs I've noticed error in the "toggleCompactMode" so I've changed folder view and then it works again.

Do you remember which folder mode you were using at the time of upgrading?

Comment 4

[juraj.masiar]

It was set to "Favorite" and "Compact view".
Note that once I changed it, I was able to change it back and now it still works, even after the restart.

Comment 5

[Alessandro Castellani [:aleca]]

Thanks for the info.
Indeed, I think I missed the proper handling of migrating from the old mode to the new one.
Apologies for the annoyance.

BTW, now you can enable multiple modes at once.

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: 1689553-folders-compact-mode.diff

This fixes it.
To recreate the issue you need to open the inspector, select the "folderTree" and update the mode attribute with "favorite_compact". Then close and relaunch TB.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9200096 [details] [diff] [review]
1689553-folders-compact-mode.diff

Review of attachment 9200096 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! r=mkmelin

::: mail/base/content/folderPane.js
@@ +378,5 @@
>        modes = modes.filter((c, index) => {
>          return modes.indexOf(c) === index;
>        });
>  
> +      // Transition from the old "*_compact" folder modes.

It would have been nicer to do as a one-time migration, but that could be a bit complicated for this case.
Please add a comment that the old=pre Thunderbird 86, so that we can just drop it some time in the future.

Comment 8

[Alessandro Castellani [:aleca]]

Attachment: 1689553-folders-compact-mode.diff

Comment updated.

Comment 9

[Alessandro Castellani [:aleca]]

Comment on attachment 9200486 [details] [diff] [review]
1689553-folders-compact-mode.diff

[Approval Request Comment]
Regression caused by (bug #): bug 1163555
User impact if declined: The UI doesn't load at startup if the user was using a _compact folder mode variation prior to 86
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3204b7a70b4d
Fix Folders Pane initialization from the old folders compact mode. r=mkmelin

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9200486 [details] [diff] [review]
1689553-folders-compact-mode.diff

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/6db8e2e76927

Comment 13

[WaltS48 [:walts48]]

Working in my test of the 86.0b2 candidate on Windows 10 and Fedora 33 Workstation.