1689603 - Non-native theme buttons could be a bit larger

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Tom S [:evilpie]]

Compared to the GTK buttons the non-native theme version looks kind of bunched together.

Comment 1

[Tom S [:evilpie]]

Attachment: GTK Button

Comment 2

[Tom S [:evilpie]]

Attachment: Non-native theme button

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Yeah, so this is kind of expected, see bug 1689098. GTK historically has had massive buttons (which cause some compat issues).

By default we have 4px padding on the sides, which matches <select>. 6px would match Chrome, 8px would match the old unthemed buttons. Does any of those two values look more appealing to you? I think we're unlikely to increase the vertical padding much.

But now that I look at it, we are overriding the border with a 1px border, but other browsers keep the 2px border width from the UA sheet. So that might give us two more pixels vertically as well.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1689603 - Return 2px border for most widgets in nsNativeBasicTheme. r=spohl,mstange

This is slightly unfortunate on one hand because we're technically lying
(but so is chromium and our GTK theme, on the other hand).

It is nice because it means that themed and unthemed controls have the
same size by default though, which seems desirable.

So I'm a bit on the edge here, but I think this is probably the less bad
option to grow our form controls if we want to do it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f869fb94e1b
Return 2px border for most widgets in nsNativeBasicTheme. r=spohl

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7522a31acf8
Fix up one XUL test.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09be0b12f032
Fix color input reftests which hard-code their height for the non-native theme.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8f869fb94e1b
https://hg.mozilla.org/mozilla-central/rev/c7522a31acf8
https://hg.mozilla.org/mozilla-central/rev/09be0b12f032