1689615 - Reddit comment box has a triple outline with non-native theme

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Tom S]

Attachment: textarea.png

On old.reddit.com there are now three outlines when commenting. One inner red, and two shades of blue. The inner red is from reddit or maybe RES.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: test-case

Comment 2

[Emilio Cobos Álvarez (:emilio)]

So this is about our focus outline-style: auto being quite large, basically... Maybe we shouldn't paint the extra outline for outline-style: auto. And maybe outline-style: auto should follow border-radius like it does on Safari. With that I think this would look fine, not sure.... thoughts?

Comment 3

[Chris Peterson [:cpeterson]]

Tracking for Fission M7 Beta. I can't reproduce on Windows.

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: Google_Doc_comment.png

I also see a triple-border when adding Google Doc comments.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

I don't see that in google docs Chris, does it repro in a clean profile?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1689615 - Only paint one outline for outline-style:auto with nnt. r=spohl,mstange

outline-style: auto might show up in non-themed controls and such, and
the double-outline there might look ugly.

Following border-radius would be an extra improvement for the reddit
case, but no platform does it currently (Safari on macOS does it), so
let's consider that in a follow-up.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/641f63f2a006
Only paint one outline for outline-style:auto with nnt. r=mstange

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson [:cpeterson] from comment #4)

I also see a triple-border when adding Google Doc comments.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

I don't see that in google docs Chris, does it repro in a clean profile?

Odd. I can no longer reproduce the Google Docs issue in my regular profile or a clean profile.

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/641f63f2a006