1689923 - Handle composition certificate exceptions

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, defect)

Description

[Ian Neal]

At the moment mail composition does not hand certificate exceptions, we should hook it up to nsMsgBadCertHandler.
Patch inspired by https://src.fedoraproject.org/rpms/seamonkey/blob/master/f/seamonkey-2.53.6-compose-cert-exception.patch

Comment 1

[Ian Neal]

Attachment: 1689923-compose-certexcept-2537.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: no cert exception dialog in composition
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 2

[Dmitry Butskoy (:buc)]

Comment on attachment 9200332 [details] [diff] [review]
1689923-compose-certexcept-2537.patch

Thanks, tested OK.

Comment 3

[Dmitry Butskoy (:buc)]

While we are here:

If you start compose from "seamonkey -mail" window (Ctrl-M), then after the typing "Confirm Exception" and/or clicking the passwd-saving checkbox, the compose window is overlapped by the main mail window. Since the mail window is usually much larger, this can be confusing for users (who will assume that mail has already been sent, when in fact the window is still waiting for confirmation in yet another popup dialog).

Note, it is NOT inspired by the latest patches, the issue existed before. But probably it could be resolved by some quick look too...

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9200332 [details] [diff] [review]
1689923-compose-certexcept-2537.patch

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0426f8ace951
Handle composition certificate exceptions. r=frg

Comment 6

[Ian Neal]

(In reply to Dmitry Butskoy from comment #3)

While we are here:

If you start compose from "seamonkey -mail" window (Ctrl-M), then after the typing "Confirm Exception" and/or clicking the passwd-saving checkbox, the compose window is overlapped by the main mail window. Since the mail window is usually much larger, this can be confusing for users (who will assume that mail has already been sent, when in fact the window is still waiting for confirmation in yet another popup dialog).

Note, it is NOT inspired by the latest patches, the issue existed before. But probably it could be resolved by some quick look too...

Please could you open a new bug for this and cc me on it?

Comment 7

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/26ff48a683419fe1265442c97169c1c14fe35a0c
Handle composition certificate exceptions. r=frg a=frg
Target 2.53.7