465978 - Port security exceptions front end piece from Thunderbird to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Robert Kaiser]

Bug 429843 did introduce a rough piece mailnews security exception UI to the Thunderbird frontend, we should adopt this on SeaMonkey as well, and follow bug 465795 later for a better implementation.

For now, let's port the simple piece, as mentioned in bug 429843 comment #79 and bug 429843 comment #88.

Comment 1

[Misak Khachatryan]

Attachment: patch

Seems easy one.

Comment 2

[Misak Khachatryan]

Attachment: correct patch

oops, i left dump() in code.

Comment 3

[Robert Kaiser]

This patch works fine for accessing an account with an invalid cert from the mail window (tested with IMAPs here) but when doing the load from the browser window to update the mailbiff icon and mailnews not open yet, it fails and still displays the "stupid" cert error dialog with no possibility to add exceptions (of course, as the callback is only installed on the actual mail window).

Comment 4

[[e-mail]]

Comment on attachment 350480 [details] [diff] [review]
correct patch

InformUserOfCertError and BadCertHandler (or should it be called nsMsgBadCertHandler?) need to live in mailTasksOverlay.js so that as some point we can hook it up to the biff code Kairo was talking about.

>+    setTimeout(InformUserOfCertError, 0, socketInfo, targetSite);
Nit: unused socketInfo

>+  var params = { exceptionAdded : false };
>+  params.prefetchCert = true;
>+  params.location = targetSite;
Nit: should write this as one big JS object instead of setting the properties separately.

Comment 5

[[e-mail]]

Comment on attachment 350480 [details] [diff] [review]
correct patch

>+    if (!iid.equals(Components.interfaces.nsIBadCertListener2) &&
>+      !iid.equals(Components.interfaces.nsIInterfaceRequestor) &&
>+      !iid.equals(Components.interfaces.nsISupports))
Nit: iid needs to line up on each line.

r+sr=me with all those nits fixed.

I tried to see if I could resolve the bad cert issue on the browser window but unfortunately whenever you have a msgWindow you get alerts for e.g. timeouts.

Comment 6

[Misak Khachatryan]

Attachment: nits fixed for checkin

Requesting r,s again, i'm not sure that i understood all right.

Comment 7

[[e-mail]]

Comment on attachment 350604 [details] [diff] [review]
nits fixed for checkin

>+    setTimeout(InformUserOfCertError, 0, socketInfo, targetSite);
...
>+function InformUserOfCertError(socketInfo, targetSite)
Nit: You never actually use socketInfo, so I don't see the point of passing it.

Comment 8

[Misak Khachatryan]

Attachment: for checkin [Checkin: Comment 9]

Last nit fixed, carrying forward r+, sr+ from Neil.

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 350607 [details] [diff] [review]
for checkin
[Checkin: Comment 9]

http://hg.mozilla.org/comm-central/rev/ba6cc9834591