169001 - Remove editorshell from EditorCommandsDebug.js

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Akkana Peck]

Remove editorshell from EditorCommandsDebug.js as part of editorshell removal.

Comment 1

[Akkana Peck]

Attachment: Patch: all but editor logging

This patch does everything except the editor logging items.  nsIEditorLogging
isn't scriptable.  I'll file a separate bug covering that (there's nothing
there that's hard to script, I guess we just thought nobody was using it) but
let's get the rest of this in without waiting for that.

"TestTableLayout" doesn't work -- lots of errors that don't seem related to my
change (complaints about not being able to get startParent).  Did it work
before?  I'll have to try it on a tree without these patches and see.

Comment 2

[Kathleen :Brade]

Comment on attachment 99597 [details] [diff] [review]
Patch: all but editor logging

this doesn't seem correct (gEditor? or GetCurrentEditor()?):
-  editorShell.InsertText(textToInsert);
+  editor.insertText(textToInsert);

what about using the function instead of "gEditor"?

Comment 3

[Akkana Peck]

Attachment: Fix the insertText problem Kathy noticed

Good catch on the insertText mistake.  Here's a new patch with that corrected
(otherwise identical).

> what about using the function instead of "gEditor"?

I thought it was okay to use gEditor in files in ui/composer/content?  No?  I'd
be happy to use the function instead, if that's better.

Comment 4

[Charles Manske]

Yes! Please use "GetCurrentEditor()" instead of "gEditor".

Comment 5

[Kathleen :Brade]

also, this QI isn't needed:
+    var htmled = gEditor.QueryInterface(Components.interfaces.nsIHTMLEditor);

r=brade with the above fix as well as Charley's string swap

Comment 6

[Akkana Peck]

Attachment: Modifications as suggested by Kathy and Charley

This changes gEditor to GetCurrentEditor() and removes the extraneous QI that
Kathy noticed.

Comment 7

[Kathleen :Brade]

Comment on attachment 100448 [details] [diff] [review]
Modifications as suggested by Kathy and Charley

r=brade

Comment 8

[Akkana Peck]

Attachment: One more minor optimization suggested by Kathy

Kathy pointed out that I didn't need the var htmled any more.

Comment 9

[Akkana Peck]

Comment on attachment 100472 [details] [diff] [review]
One more minor optimization suggested by Kathy

Transferring Kathy's r= from the last patch.  Kin, could you sr this?

Comment 10

[kinmoz]

Comment on attachment 100472 [details] [diff] [review]
One more minor optimization suggested by Kathy

sr=[e-mail]

Should we be concerned with the possibility |GetCurrentEditor()| will return
null? Or is that highly unlikely?

Comment 11

[Akkana Peck]

Its highly unlikely, but if it happens, given that these are all debug-menu
items, letting the exception get thrown is probably the right thing to do anyway.

Fix is in.