121648 - (editorshell) remove editorshell

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Kathleen :Brade]

remove editorshell from build and cvs

Comment 1

[Akkana Peck]

Hope to have dependencies out by 0.9.9, but actual removal can wait for 1.0.

Comment 2

[Akkana Peck]

I don't think there's much chance that the actual removal will happen before 1.0.

The APIs are now in place so that users CAN use the nsIEditor interfaces, and
avoid the editorshell, and there are comments in several places telling them to
do this (we should update our documentation on mozilla.org too, since I think we
have some pointing to editorshell).  But making all the changes to editor and
mail to where we can actually remove the editorshell will have to wait.

Removing nsbeta+ and requesting re-evaluation -- suggest minusing.

Comment 3

[Akkana Peck]

Nobody's evaluating these, I guess.  Bumping milestone.

Comment 4

[Akkana Peck]

Changing milestone to reflect realities of bug 122922.

Comment 5

[mjudge]

catch all bug for composer proper work. This is dependent on the work being 
done to remove nsIEditorShell calls and make the calls directly to the 
nsIEditor.  Once this is done the concurrent work on the editor tag ect should 
be finished then we make 1 more pass to remove nsIEditor nsIPlainTextEditor and 
nsIHTMLEditor calls with calls to nsICommandManager.  at that point editor 
shell will be gone.  I will leave this bug with akkanna

Comment 6

[mjudge]

*** Bug 157097 has been marked as a duplicate of this bug. ***

Comment 7

[mjudge]

*** Bug 157104 has been marked as a duplicate of this bug. ***

Comment 8

[Akkana Peck]

Mike accidentally marked this NEW instead of ASSIGNED.  "Catch-all" isn't really
the right description for this bug; it covers the actual removal of the
editorshell class, and since that can't happen until editor embedding is usable
and all references to the editorshell have been removed, it also works nicely as
a tracking bug for those issues.  In fact, since it's useful as a tracking bug
I'm giving it the keyword: editorshell (though it can also be found through the
dependencies of the "edembed" tracking bug).

Comment 9

[Akkana Peck]

Pushing out milestone because of dependencies.

Comment 10

[Kathleen :Brade]

Attachment: removing code that is no longer used in mozilla or commercial

Although the middle of the editorshell file looks strange, I really only
deleted stuff (I added a couple blank lines so it wouldn't show as much in the
diff).

Comment 11

[kinmoz]

Comment on attachment 100915 [details] [diff] [review]
removing code that is no longer used in mozilla or commercial

Yeah it is strange that you had to add those blank lines to make the diff
easier to read. Just make sure they are removed before checkin ... I hate it
when diff gets confused.

Also, delete the editor core stuff you commented out if they aren't needed.

sr=[e-mail]

Comment 12

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 100915 [details] [diff] [review]
removing code that is no longer used in mozilla or commercial

r=glazman

Comment 13

[Charles Manske]

All remaining bugfixes checked into 1.3a trunk

Comment 14

[Kathleen :Brade]

reopening; these are not removed according to lxr:
  *editorshell.cpp, *.h, nsIEditorShell.idl, editorshellfactory*, nsInterfaceState.*

Comment 15

[Charles Manske]

The remaining items found by brade are fixed in the patch on bug 169029

Comment 16

[Akkana Peck]

Editorshell is gone!  Yay Charley!

Comment 17

[Kathleen :Brade]

I do see other code in mozilla that uses editorshell but they should probably be
dealt with outside of this bug:

/mail/components/compose/content/MsgComposeCommands.js, line 1387
/toolkit/content/widgets/general.xml, line 183

Comment 18

[sairuh (rarely reading bugmail)]

i did an lxr search for "editorshell", and only found it mentioned in
/extensions/editor/cascades/resources/content/EdCssProps.js

rs vrfy --but if there are other issues pertaining to this bug, other (new) bugs
should prolly be filed separately.