1690141 - Popup window not closed anymore

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[C-E]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Run Add-on "Textmarker" Version 5.0.1
In compose window click "Ctrl"+Mark-Button to get colour change popup.
Click on a colour.

Actual results:

Colour is taken, sound is played, but popup window is not closed.

(If browser.tabs.remote.autostart is set to false, the popup windows is closed as intended.)

Expected results:

Popup window should close automatically after colour picking.

Code in popup.js:
window.setTimeout(closewin, 700);
function closewin() {
window.close();
}

Comment 1

[John Bieling (:TbSync)]

Yes, it is related to e10s being enabled. If you toggle the browser.tabs.remote.autostart preference and restart Thunderbird, it works again.

Comment 2

[C-E]

In 86.0b2 with browser.tabs.remote.autostart set to true, popup window closes as intended - problem seems to be resolved.

Comment 3

[John Bieling (:TbSync)]

Do we know which bug could have fixed this?

Comment 4

[C-E]

I'm sorry, maybe I made a mistake when toggling the pref ...
In any case, in 86.0b3 the problem still exists (or exists again).

Comment 5

[C-E]

Just tested 87.0b1: the problem still exists.

Comment 6

[John Bieling (:TbSync)]

Attachment: Bug 1690141 - Fix window.close() in extension popup windows. r=darktrojan

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/75e8be79df16
Fix window.close() in extension popup windows. r=darktrojan DONTBUILD