1690450 - [Debugger] more granular ignore for step-by-step in the debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Karl Dubost💡 :karlcow]

Currently the debugger makes it possible to ignore a full file when doing step by step. The eye icon at the bottom left.

It would be great to be able to have a similar feature

1. for functions

// [crossed_eye]   
function blah() {
   //plenty of code
}

would make it possible to ignore the step in for this function and just go to the next instruction.

2. for loop code

// [crossed_eye] 
for (let i = 0; i < 10000; i++) {
  str = str + i;
}

You would just jump at the } after the loop has finished

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Steve, are there good platform API we could use to ignore specific functions and/or loops when stepping?
(please let me know if there is anyone else who could know the answer)
From the UI perspective we could introduce some kind of an opposite to a breakpoints saying "Never pause here".

Thank you!

Honza

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1690450 - [devtools] Add pref for blackboxing lines r=ochameau

Depends on D132050

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1690450 - [devtools] Rename the getSourceId to getBlackboxRangeForSource r=ochameau

Depends on D132052

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1690450 - [devtools] Implement blackboxing lines UI functionality

Depends on D132138

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b264a14f5258
[devtools] Add pref for blackboxing lines r=ochameau
https://hg.mozilla.org/integration/autoland/rev/314f2ff57cc9
[devtools] Rename the getSourceId to getBlackboxRangeForSource r=ochameau

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b264a14f5258
https://hg.mozilla.org/mozilla-central/rev/314f2ff57cc9

Comment 7

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1690450 - [devtools] Add blackbox line support for actions and reducers

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

As we're working on this area and wondering about UI, note that we do have prior discussion regarding blackboxing/ignoring in https://github.com/firefox-devtools/ux/issues/84
(the idea was to have a crossed-file icon, some text label to make it explicit and use another color than blue)

Comment 9

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1690450 - [devtools] Remove unused tabBlackboxed pref

Comment 10

[Phabricator Automation]

Comment on attachment 9254133 [details]
Bug 1690450 - [devtools] Remove unused tabBlackboxed pref

Revision D133095 was moved to bug 1745921. Setting attachment 9254133 [details] to obsolete.

Comment 11

[Hubert Boma Manilla (:bomsy)]

See Bug 1745940 for implementation of blackboxing lines

Comment 12

[Phabricator Automation]

Comment on attachment 9253586 [details]
Bug 1690450 - [devtools] Add blackbox line support for actions and reducers

Revision D132774 was moved to bug 1745940. Setting attachment 9253586 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9252856 [details]
Bug 1690450 - [devtools] Implement blackboxing lines UI functionality

Revision D132368 was moved to bug 1745940. Setting attachment 9252856 [details] to obsolete.